Fix defineTable({ ...v.object({}) }) handling (#37561)

When writing code like `defineTable({ ...v.object({}) })`, the validator’s attributes are copied but not getters, including `json` which is used during the table definition export.

This means that `export` would silently fail, as it did for someone on Discord (https://discord.com/channels/1019350475847499849/1019350478817079338/1374853725491036270). Other schema definition errors are handled by the backend, but this one isn’t since `document_type: None` is a valid attribute value in `TableDefinitionJson`.

`export` in `TableDefinition` is the only `export` method where we’re calling a JavaScript getter, so other code paths should be fine.

GitOrigin-RevId: 392fa3b7cbd1939dae8349e01dcde8ea2e29c079

Author: Nicolapps

npm-packages/convex/src/server/schema.test.ts

@@ -749,3 +749,13 @@ describe("defineSchema/defineTable expose table validators", () => {
     expect(schema.tables.table.validator).not.toHaveProperty("_creationTime");
   });
 });
+
+test("defineTable fails if it can’t export the validator", () => {
+  const table = defineTable(
+    // @ts-expect-error
+    { ...v.object({}) }, // This will clone `isConvexValidator` but not the `json` getter used by `export`
+  );
+  expect(() => table.export()).toThrow(
+    "Invalid validator: please make sure that the parameter of `defineTable` is valid (see https://docs.convex.dev/database/schemas)",
+  );
+});

npm-packages/convex/src/server/schema.ts

@@ -310,11 +310,18 @@ export class TableDefinition<
    * @internal
    */
   export() {
+    const documentType = this.validator.json;
+    if (typeof documentType !== "object") {
+      throw new Error(
+        "Invalid validator: please make sure that the parameter of `defineTable` is valid (see https://docs.convex.dev/database/schemas)",
+      );
+    }
+
     return {
       indexes: this.indexes,
       searchIndexes: this.searchIndexes,
       vectorIndexes: this.vectorIndexes,
-      documentType: this.validator.json,
+      documentType,
     };
   }
 }