Increase idle instance max_repeatable bump (#25057)

jordanhunt22 · Convex, Inc. · commit ab2ded765409 · 2024-04-25T23:11:40.000Z
Increase the amount of time between bumps of `max_repeatable` for idle instances. I tested locally confirmed that this will reduce the queries of the retention globals ~2.5x for idle instances.

GitOrigin-RevId: 1de0a7ce6b249c694e57e8604572e38313a0886e
diff --git a/crates/common/src/knobs.rs b/crates/common/src/knobs.rs
@@ -269,7 +269,7 @@ pub static TRANSACTION_MAX_READ_SET_INTERVALS: LazyLock<usize> =
 pub static MAX_REPEATABLE_TIMESTAMP_IDLE_FREQUENCY: LazyLock<Duration> = LazyLock::new(|| {
     Duration::from_secs(env_config(
         "MAX_REPEATABLE_TIMESTAMP_IDLE_FREQUENCY",
-        2 * 60,
+        5 * 60,
     ))
 });
 
diff --git a/crates/database/src/retention.rs b/crates/database/src/retention.rs
@@ -441,7 +441,7 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {
         Self::get_checkpoint(
             persistence.reader().as_ref(),
             snapshot_reader.clone(),
-            RetentionType::Index,
+            retention_type,
         )
         .await?;
         Ok(Some(new_min_snapshot_ts))

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {`
`441`	`441`	`Self::get_checkpoint(`
`442`	`442`	`persistence.reader().as_ref(),`
`443`	`443`	`snapshot_reader.clone(),`
`444`		`- RetentionType::Index,`
	`444`	`+ retention_type,`
`445`	`445`	`)`
`446`	`446`	`.await?;`
`447`	`447`	`Ok(Some(new_min_snapshot_ts))`