Revert "Dashboard uses indexes system UDF" (#39151)

Reverts get-convex/convex#39048

GitOrigin-RevId: 31ac1a5c80044d4688c009f4a898e3b3769f0447

Author: emmaling27

npm-packages/dashboard-common/src/features/data/components/DataContent.tsx

@@ -50,11 +50,9 @@ import {
   PanelGroup,
 } from "react-resizable-panels";
 import { cn } from "@ui/cn";
-
+import { useTableIndexes } from "@common/features/data/lib/api";
 import { getDefaultIndex } from "@common/features/data/components/DataFilters/IndexFilters";
 import { useMount } from "react-use";
-import { api } from "system-udfs/convex/_generated/api";
-import { useNents } from "@common/lib/useNents";
 
 export function DataContent({
   tableName,
@@ -181,12 +179,7 @@ export function DataContent({
   const selectedDocumentId = rowsThatAreSelected.values().next().value;
   const selectedDocument = data.find((row) => row._id === selectedDocumentId);
   const defaultDocument = useDefaultDocument(tableName);
-  const { selectedNent } = useNents();
-  const indexes =
-    useQuery(api._system.frontend.indexes.default, {
-      tableName,
-      componentId: selectedNent?.id ? selectedNent.id : null,
-    }) ?? undefined;
+  const { indexes } = useTableIndexes(tableName);
   const sortField =
     (
       indexes?.find((index) => index.name === filters?.index?.name)?.fields as

npm-packages/dashboard-common/src/features/data/components/DataFilters/DataFilters.stories.tsx

@@ -16,11 +16,7 @@ const deployment: ConnectedDeployment = {};
 const mockClient = mockConvexReactClient()
   .registerQueryFake(udfs.listById.default, ({ ids }) => ids.map(() => null))
   .registerQueryFake(udfs.getVersion.default, () => "0.19.0")
-  .registerQueryFake(udfs.components.list, () => [])
-  .registerQueryFake(
-    udfs.indexes.default,
-    ({ tableName: _tableName, componentId: _componentId }) => [],
-  );
+  .registerQueryFake(udfs.components.list, () => []);
 
 export default {
   component: DataFilters,

npm-packages/dashboard-common/src/features/data/components/DataFilters/DataFilters.tsx

@@ -37,10 +37,8 @@ import {
 } from "@common/features/data/components/Table/utils/validators";
 import { useFilterHistory } from "@common/features/data/lib/useTableFilters";
 import { cn } from "@ui/cn";
+import { useTableIndexes } from "@common/features/data/lib/api";
 import { DeploymentInfoContext } from "@common/lib/deploymentContext";
-import { useNents } from "@common/lib/useNents";
-import { useQuery } from "convex/react";
-import { api } from "system-udfs/convex/_generated/api";
 import { IndexFilterState } from "./IndexFilterEditor";
 import { IndexFilters, getDefaultIndex } from "./IndexFilters";
 
@@ -77,12 +75,7 @@ export function DataFilters({
   showFilters: boolean;
   setShowFilters: React.Dispatch<React.SetStateAction<boolean>>;
 }) {
-  const { selectedNent } = useNents();
-  const indexes =
-    useQuery(api._system.frontend.indexes.default, {
-      tableName,
-      componentId: selectedNent?.id ? selectedNent.id : null,
-    }) ?? undefined;
+  const { indexes } = useTableIndexes(tableName);
   const {
     isDirty,
     hasInvalidFilters,

npm-packages/dashboard-common/src/features/data/components/IndexList.tsx

@@ -1,10 +1,8 @@
 import React from "react";
-import { Index } from "@common/features/data/lib/api";
+import { Index, useTableIndexes } from "@common/features/data/lib/api";
+import { Callout } from "@ui/Callout";
 import { Spinner } from "@ui/Spinner";
 import { Tooltip } from "@ui/Tooltip";
-import { useQuery } from "convex/react";
-import { api } from "system-udfs/convex/_generated/api";
-import { useNents } from "@common/lib/useNents";
 
 function IndexRow({ index }: { index: Index }) {
   const { type, fields } = getIndexDescription(index);
@@ -68,12 +66,11 @@ export function IndexesList({ indexes }: { indexes?: Index[] }) {
 }
 
 export function IndexList({ tableName }: { tableName: string }) {
-  const { selectedNent } = useNents();
-  const indexes =
-    useQuery(api._system.frontend.indexes.default, {
-      tableName,
-      componentId: selectedNent?.id ? selectedNent.id : null,
-    }) ?? undefined;
+  const { indexes, hadError } = useTableIndexes(tableName);
 
-  return <IndexesList indexes={indexes} />;
+  return hadError ? (
+    <Callout variant="error">Encountered an error loading indexes.</Callout>
+  ) : (
+    <IndexesList indexes={indexes} />
+  );
 }

npm-packages/dashboard-common/src/features/data/lib/api.ts

@@ -1,10 +1,14 @@
 import { useCallback, useContext } from "react";
-import { useSWRConfig } from "swr";
+import useSWR, { useSWRConfig } from "swr";
 import {
   useDeploymentUrl,
   useAdminKey,
   useDeploymentAuthHeader,
+  deploymentAuthMiddleware,
+  useDeploymentIsDisconnected,
 } from "@common/lib/deploymentApi";
+import { deploymentFetch } from "@common/lib/fetching";
+import { useNents } from "@common/lib/useNents";
 import { DeploymentInfoContext } from "@common/lib/deploymentContext";
 
 export function useDeleteTables(): (
@@ -46,7 +50,7 @@ export const useInvalidateShapes = () => {
 };
 
 export type Index = {
-  table?: string;
+  table: string;
   name: string;
   fields:
     | string[]
@@ -61,9 +65,27 @@ export type Index = {
       };
   backfill: {
     state: "in_progress" | "done";
-    stats?: {
-      numDocsIndexed: number;
-      totalDocs: number;
-    };
   };
 };
+
+export function useTableIndexes(tableName: string): {
+  indexes?: Index[];
+  hadError: boolean;
+} {
+  const { selectedNent } = useNents();
+  const query = selectedNent ? `?componentId=${selectedNent.id}` : "";
+  const isDisconnected = useDeploymentIsDisconnected();
+  const { data, error } = useSWR<{ indexes: Index[] }>(
+    isDisconnected ? null : `/api/get_indexes${query}`,
+    deploymentFetch,
+    {
+      use: [deploymentAuthMiddleware],
+      shouldRetryOnError: false,
+    },
+  );
+
+  return {
+    hadError: !!error,
+    indexes: data?.indexes.filter((index) => index.table === tableName),
+  };
+}