Allow CONVEX_CONFIG_PATH to be a environment variable #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that users can swap convex login state (or leave it blank) when using the convex cli. remove unneeded import
|
I'm not sure what the style choice here is, What's your style advice here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of CONVEX_DEPLOY_KEY changes depending on if the current user is logged into convex via the CLI. This has some unintended consequences for users with a large number of projects.
The current behavior is correct for about 99% of Convex developers, however, in some cases (those with a very large number of projects) it limits their ability to deploy. The temp solution is to remove or rename the $HOME/.convex/config.json in order to allow deployment to a project that the user isn't a member of.
By allow this to be an environment variable it allows a user, at deploy time, to determine with auth details (or lack thereof) are used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.