Leave legacy query as default runner for now

distantnative · distantnative · commit d55ac78a953a · 2025-01-24T23:13:27.000+01:00
diff --git a/src/Query/Argument.php b/src/Query/Argument.php
@@ -15,7 +15,7 @@
  * @copyright Bastian Allgeier
  * @license   https://opensource.org/licenses/MIT
  *
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class Argument
 {
diff --git a/src/Query/Arguments.php b/src/Query/Arguments.php
@@ -15,7 +15,7 @@
  * @copyright Bastian Allgeier
  * @license   https://opensource.org/licenses/MIT
  *
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  *
  * @extends \Kirby\Toolkit\Collection<\Kirby\Query\Argument>
  */
diff --git a/src/Query/Expression.php b/src/Query/Expression.php
@@ -15,7 +15,7 @@
  * @copyright Bastian Allgeier
  * @license   https://opensource.org/licenses/MIT
  *
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class Expression
 {
diff --git a/src/Query/Query.php b/src/Query/Query.php
@@ -76,9 +76,10 @@ public function resolve(array|object $data = []): mixed
 			return $data;
 		}
 
+		// TODO: switch to 'interpreted' as default in v6
 		// TODO: remove in v7
 		// @codeCoverageIgnoreStart
-		$mode = App::instance()->option('query.runner', 'interpreted');
+		$mode = App::instance()->option('query.runner', 'legacy');
 
 		if ($mode === 'legacy') {
 			return $this->resolve_legacy($data);
diff --git a/src/Query/Segment.php b/src/Query/Segment.php
@@ -17,7 +17,7 @@
  * @copyright Bastian Allgeier
  * @license   https://opensource.org/licenses/MIT
  *
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class Segment
 {
diff --git a/src/Query/Segments.php b/src/Query/Segments.php
@@ -15,7 +15,7 @@
  * @copyright Bastian Allgeier
  * @license   https://opensource.org/licenses/MIT
  *
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  *
  * @extends \Kirby\Toolkit\Collection<\Kirby\Query\Segment>
  */
diff --git a/tests/Query/ArgumentTest.php b/tests/Query/ArgumentTest.php
@@ -7,7 +7,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Query\Argument
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class ArgumentTest extends TestCase
 {
diff --git a/tests/Query/ArgumentsTest.php b/tests/Query/ArgumentsTest.php
@@ -6,7 +6,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Query\Arguments
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class ArgumentsTest extends TestCase
 {
diff --git a/tests/Query/ExpressionTest.php b/tests/Query/ExpressionTest.php
@@ -7,7 +7,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Query\Expression
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class ExpressionTest extends TestCase
 {
diff --git a/tests/Query/QueryInterpretedTest.php b/tests/Query/QueryInterpretedTest.php
@@ -12,8 +12,19 @@
 /**
  * @coversDefaultClass \Kirby\Query\Query
  */
-class QueryTest extends TestCase
+class QueryInterpretedTest extends TestCase
 {
+	protected function setUp(): void
+	{
+		new App([
+			'options' => [
+				'query' => [
+					'runner' => 'interpreted'
+				]
+			]
+		]);
+	}
+
 	protected function tearDown(): void
 	{
 		App::destroy();
diff --git a/tests/Query/QueryLegacyTest.php b/tests/Query/QueryLegacyTest.php
@@ -0,0 +1,94 @@
+<?php
+
+namespace Kirby\Query;
+
+use Closure;
+
+/**
+ * @coversDefaultClass \Kirby\Query\Query
+ */
+class QueryLegacyTest extends \PHPUnit\Framework\TestCase
+{
+	/**
+	 * @covers ::__construct
+	 * @covers ::factory
+	 */
+	public function testFactory()
+	{
+		$query = Query::factory(' user.me ');
+		$this->assertSame('user.me', $query->query);
+	}
+
+	/**
+	 * @covers ::intercept
+	 */
+	public function testIntercept()
+	{
+		$query = new Query('kirby');
+		$this->assertSame('foo', $query->intercept('foo'));
+	}
+
+	/**
+	 * @covers ::resolve
+	 */
+	public function testResolve()
+	{
+		$query = new Query("user.self.likes(['(', ')']).self.drink");
+		$data  = ['user' => new TestUser()];
+		$this->assertSame(['gin', 'tonic', 'cucumber'], $query->resolve($data));
+	}
+
+	/**
+	 * @covers ::resolve
+	 */
+	public function testResolveWithEmptyQuery()
+	{
+		$query = new Query('');
+		$data = ['foo' => 'bar'];
+		$this->assertSame($data, $query->resolve($data));
+	}
+
+	/**
+	 * @covers ::resolve
+	 */
+	public function testResolveWithComparisonExpresion()
+	{
+		$query = new Query('user.nothing ?? (user.nothing ?? user.isYello(false)) ? user.says("error") : (user.nothing ?? user.says("success"))');
+		$data  = ['user' => new TestUser()];
+		$this->assertSame('success', $query->resolve($data));
+	}
+
+	/**
+	 * @covers ::resolve
+	 */
+	public function testResolveWithExactArrayMatch()
+	{
+		$query = new Query('user');
+		$this->assertSame('homer', $query->resolve(['user' => 'homer']));
+
+		$query = new Query('user.username');
+		$this->assertSame('homer', $query->resolve(['user.username' => 'homer']));
+
+		$query = new Query('user.callback');
+		$this->assertSame('homer', $query->resolve(['user.callback' => fn () => 'homer']));
+	}
+
+	/**
+	 * @covers ::resolve
+	 */
+	public function testResolveWithClosureArgument()
+	{
+		$query = new Query('foo.bar(() => foo.homer)');
+		$data  = [
+			'foo' => [
+				'bar'   => fn ($callback) => $callback,
+				'homer' => 'simpson'
+			]
+		];
+
+		$bar = $query->resolve($data);
+		$this->assertInstanceOf(Closure::class, $bar);
+		$bar = $bar();
+		$this->assertSame('simpson', $bar);
+	}
+}
diff --git a/tests/Query/SegmentTest.php b/tests/Query/SegmentTest.php
@@ -36,7 +36,7 @@ public function __get($name)
 
 /**
  * @coversDefaultClass \Kirby\Query\Segment
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class SegmentTest extends TestCase
 {
diff --git a/tests/Query/SegmentsTest.php b/tests/Query/SegmentsTest.php
@@ -9,7 +9,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Query\Segments
- * @deprecated 6.0.0 Will be removed in Kirby 7
+ * @todo Deprecate in v6
  */
 class SegmentsTest extends TestCase
 {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`* @copyright Bastian Allgeier`
`16`	`16`	`* @license https://opensource.org/licenses/MIT`
`17`	`17`	`*`
`18`		`- * @deprecated 6.0.0 Will be removed in Kirby 7`
	`18`	`+ * @todo Deprecate in v6`
`19`	`19`	`*/`
`20`	`20`	`class Argument`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`* @copyright Bastian Allgeier`
`18`	`18`	`* @license https://opensource.org/licenses/MIT`
`19`	`19`	`*`
`20`		`- * @deprecated 6.0.0 Will be removed in Kirby 7`
	`20`	`+ * @todo Deprecate in v6`
`21`	`21`	`*/`
`22`	`22`	`class Segment`
`23`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`/**`
`9`	`9`	`* @coversDefaultClass \Kirby\Query\Argument`
`10`		`- * @deprecated 6.0.0 Will be removed in Kirby 7`
	`10`	`+ * @todo Deprecate in v6`
`11`	`11`	`*/`
`12`	`12`	`class ArgumentTest extends TestCase`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`/**`
`8`	`8`	`* @coversDefaultClass \Kirby\Query\Arguments`
`9`		`- * @deprecated 6.0.0 Will be removed in Kirby 7`
	`9`	`+ * @todo Deprecate in v6`
`10`	`10`	`*/`
`11`	`11`	`class ArgumentsTest extends TestCase`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`/**`
`9`	`9`	`* @coversDefaultClass \Kirby\Query\Expression`
`10`		`- * @deprecated 6.0.0 Will be removed in Kirby 7`
	`10`	`+ * @todo Deprecate in v6`
`11`	`11`	`*/`
`12`	`12`	`class ExpressionTest extends TestCase`
`13`	`13`	`{`