Skip to content

feat: Remove license button/dialog #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 29, 2025

Description

Screenshot 2025-07-14 at 20 00 31 Screenshot 2025-07-14 at 20 00 35

Summary of changes

  • License dialog includes button to remove license file

Reasoning

#6960

Changelog

Enhancement

  • License dialog includes button to remove license file

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.0.0-beta.3 milestone Jan 29, 2025
@distantnative distantnative self-assigned this Jan 29, 2025
@distantnative distantnative linked an issue Jan 29, 2025 that may be closed by this pull request
@bastianallgeier
Copy link
Member

The text is more tricky than I thought. What about something like this?

Screenshot 2025-02-03 at 11 36 48

But this would not explain what happens to the current license. We could still add it below but the text gets quite long.

Maybe we need a "read more" link with additional explanation on our site?

@distantnative
Copy link
Member Author

Read more link sounds sensible

@distantnative distantnative force-pushed the v5/enhancement/license-remove-button branch from 32867b1 to 12ba1ea Compare February 7, 2025 14:32
@distantnative distantnative marked this pull request as ready for review February 7, 2025 14:33
@distantnative distantnative force-pushed the v5/enhancement/license-remove-button branch from 12ba1ea to f9e9f06 Compare February 7, 2025 14:43
@distantnative distantnative modified the milestones: 5.0.0-beta.3, 5.1.0 Feb 10, 2025
@distantnative distantnative marked this pull request as draft February 10, 2025 09:21
@distantnative distantnative changed the title License dialog: remove button feat: Remove license button/dialog May 25, 2025
@distantnative distantnative force-pushed the v5/enhancement/license-remove-button branch from 95790a7 to 17f4cbf Compare May 25, 2025 13:01
@distantnative distantnative changed the base branch from v5/develop to v5/feat/license-delete May 25, 2025 13:02
@distantnative distantnative force-pushed the v5/feat/license-delete branch 2 times, most recently from 9ab4cf3 to 46edffa Compare June 24, 2025 21:10
Base automatically changed from v5/feat/license-delete to develop-minor July 14, 2025 10:50
@distantnative distantnative force-pushed the v5/enhancement/license-remove-button branch from 17f4cbf to 5960dee Compare July 14, 2025 10:57
@distantnative distantnative force-pushed the v5/enhancement/license-remove-button branch from 5960dee to 3e26cc7 Compare July 14, 2025 10:57
@distantnative distantnative marked this pull request as ready for review July 14, 2025 11:01
@distantnative distantnative requested a review from a team July 14, 2025 11:01
@bastianallgeier
Copy link
Member

Still struggling with the text a bit. Here's another try …

Screenshot 2025-07-14 at 13 43 57

@distantnative
Copy link
Member Author

👍

@bastianallgeier bastianallgeier force-pushed the v5/enhancement/license-remove-button branch from ce3c16c to e5afd01 Compare July 14, 2025 12:15
@bastianallgeier bastianallgeier merged commit 468d24a into develop-minor Jul 14, 2025
14 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/license-remove-button branch July 14, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Option to delete a license from the panel
2 participants