Skip to content

Page Create Dialog: no validation for drafts #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
distantnative opened this issue Mar 20, 2025 · 3 comments · May be fixed by #7101
Open

Page Create Dialog: no validation for drafts #7079

distantnative opened this issue Mar 20, 2025 · 3 comments · May be fixed by #7101
Assignees
Milestone

Comments

@distantnative
Copy link
Member

Currently, the backend part of the dialog only validates the field if a published page not a draft will be created (correct). However, the native browser validation still kicks in and prevents the dialog to be submitted even for drafts.

We should consider if for drafts the native browser validation can be prevented. Maybe a minimal solution could be at least to prevent the required attribute.

@bastianallgeier
Copy link
Member

There are two options:

  • We set novalidate in form element in the Dialog.vue component.
  • We remove the required prop from all custom fields on the backend.

The problem here is that we ideally want a mixed solution. Title and slug should still be required, but the rest may be skipped.

@distantnative
Copy link
Member Author

Could we use formnovalidate on the other inputs but title and slug?

@bastianallgeier
Copy link
Member

We could introduce that as a global attribute for all fields.

@distantnative distantnative linked a pull request Mar 29, 2025 that will close this issue
5 tasks
@distantnative distantnative self-assigned this Mar 29, 2025
@distantnative distantnative added this to the 5.1.0 milestone Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants