fix: External preview URLs #7256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Merge first
Description
Summary of changes
Reasoning
url
option, but is not very likely in practice. If it happens, it can be fixed by fixing the customurl
setup. This was the reason why I originally decided to use the relative path (which made external previews impossible), but for the headless use-case we need the external preview support and so this solution seems to be the most solid overall.Changelog
Fixes since v5 beta
Breaking changes since v5 beta
Docs
None
Ready?
For review team