fix: SSL certificate error on proxy configured browser launch

[RohitR311]

What this PR does?

It sets parameters to ignore certificate errors on launching chromium browser instance.

Summary by CodeRabbit

• New Features
  • Improved browser compatibility by allowing the browser to ignore SSL certificate errors during certain operations.

[coderabbitai]

Walkthrough

The changes introduce the "--ignore-certificate-errors" Chromium launch argument in two locations: within the RemoteBrowser class and the /test route. This ensures that browser instances launched from these areas will ignore SSL certificate errors. No other logic or control flow is altered.

Changes

File(s)	Change Summary
server/src/browser-management/classes/RemoteBrowser.ts server/src/routes/proxy.ts	Added the "--ignore-certificate-errors" Chromium launch argument to browser launch options.

Possibly related PRs

• fix: handling unexpected browser context closed error #498: Modifies the same initialize method in RemoteBrowser to implement retry logic and error handling for browser launch failures, which overlaps with the area changed in this PR.

Suggested reviewers

• amhsirak

Poem

A flag for Chromium, a hop in the code,
SSL errors now take the less-traveled road.
Browsers launch bravely, with nary a care,
Certificates faulty? We simply won’t stare!
CodeRabbit hops by, with a wink and a cheer,
For smoother connections, let’s all give a hear!
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

server/src/browser-management/classes/RemoteBrowser.ts (1)

286-287: Approval with security consideration

The addition of the --ignore-certificate-errors flag effectively addresses the SSL certificate error issue when using proxy configurations. This change aligns with the change in proxy.ts.

However, bypassing certificate validation has security implications. While acceptable for a controlled environment, it could potentially expose the application to man-in-the-middle attacks if used carelessly.

Consider adding a code comment explaining why this flag is necessary, and potentially making it configurable based on the environment (development vs. production).

server/src/routes/proxy.ts (2)

92-92: Consistent solution with security implications

The addition of the --ignore-certificate-errors flag is consistent with the change in RemoteBrowser.ts and effectively addresses SSL certificate errors when testing proxy connections.

As with the other instance, bypassing certificate validation has security implications, though it's less concerning for a test endpoint that uses a controlled destination (example.com).

Consider updating line 92 to maintain consistent formatting with the rest of the codebase:

-            args:["--ignore-certificate-errors"]
+            args: ["--ignore-certificate-errors"]

---

164-165: Unrelated TODO comment should be addressed

There's an unrelated TODO comment indicating this function should be moved elsewhere. Since you're modifying code in this file, consider addressing this TODO.

This function appears to be used in the RemoteBrowser.ts file, so it could potentially be moved to a separate utility file for proxy-related functions.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d102f1 and 6c2bd08.

📒 Files selected for processing (2)

• server/src/browser-management/classes/RemoteBrowser.ts (1 hunks)
• server/src/routes/proxy.ts (1 hunks)