-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Replace Redis with Valkey #3868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 182 182
Misses 1 1 ☔ View full report in Codecov by Sentry. |
It's nice to experiment with this, but could cause some pain for us to maintain self-hosted since prod uses redis |
While valkey is a great replacement - I think Redis 8 should be the natural next-step - We're running I haven't measured how much throughput is actually in Redis, by default (vs kafka vs postgresql for instance). But if Celery + rate limits + something-else is running there, there must be some. I can test out 8.2 with increased io-threads over the next few weeks in our prod. |
I think Redis 8's license is okay to use in this repo? @gavin-zee? -- https://redis.io/legal/licenses/ |
@BYK nevertheless, aren't we currently running Redis 6 on SaaS? |
@aldy505 good to be prepared. Also I didn't look who wrote the |
Caution
This is me playing around with Valkey as a Redis replacement, since so many people from the community mentioned Valkey already.
There is no guarantee that this will be merged at all.