Remove unused store endpoint (#5446)

Author: noahsmartin

Sources/Sentry/SentryNSURLRequest.m

@@ -19,49 +19,6 @@
 
 @implementation SentryNSURLRequest
 
-- (_Nullable instancetype)initStoreRequestWithDsn:(SentryDsn *)dsn
-                                         andEvent:(SentryEvent *)event
-                                 didFailWithError:(NSError *_Nullable *_Nullable)error
-{
-    NSDictionary *serialized = [event serialize];
-    NSData *jsonData = [SentrySerialization dataWithJSONObject:serialized];
-    if (nil == jsonData) {
-        SENTRY_LOG_ERROR(@"Event cannot be converted to JSON");
-        return nil;
-    }
-
-    if ([SentrySDK.currentHub getClient].options.debug == YES) {
-        SENTRY_LOG_DEBUG(@"Sending JSON -------------------------------");
-        SENTRY_LOG_DEBUG(
-            @"%@", [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding]);
-        SENTRY_LOG_DEBUG(@"--------------------------------------------");
-    }
-    return [self initStoreRequestWithDsn:dsn andData:jsonData didFailWithError:error];
-}
-
-- (_Nullable instancetype)initStoreRequestWithDsn:(SentryDsn *)dsn
-                                          andData:(NSData *)data
-                                 didFailWithError:(NSError *_Nullable *_Nullable)error
-{
-    NSURL *apiURL = [dsn getStoreEndpoint];
-    self = [super initWithURL:apiURL
-                  cachePolicy:NSURLRequestReloadIgnoringLocalCacheData
-              timeoutInterval:SentryRequestTimeout];
-    if (self) {
-        NSString *authHeader = newAuthHeader(dsn.url);
-
-        self.HTTPMethod = @"POST";
-        [self setValue:authHeader forHTTPHeaderField:@"X-Sentry-Auth"];
-        [self setValue:@"application/json" forHTTPHeaderField:@"Content-Type"];
-        [self setValue:[NSString
-                           stringWithFormat:@"%@/%@", SentryMeta.sdkName, SentryMeta.versionString]
-            forHTTPHeaderField:@"User-Agent"];
-        [self setValue:@"gzip" forHTTPHeaderField:@"Content-Encoding"];
-        self.HTTPBody = sentry_gzippedWithCompressionLevel(data, -1, error);
-    }
-    return self;
-}
-
 - (_Nullable instancetype)initEnvelopeRequestWithDsn:(SentryDsn *)dsn
                                              andData:(NSData *)data
                                     didFailWithError:(NSError *_Nullable *_Nullable)error

Sources/Sentry/include/SentryNSURLRequest.h

@@ -7,14 +7,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface SentryNSURLRequest : NSMutableURLRequest
 
-- (_Nullable instancetype)initStoreRequestWithDsn:(SentryDsn *)dsn
-                                         andEvent:(SentryEvent *)event
-                                 didFailWithError:(NSError *_Nullable *_Nullable)error;
-
-- (_Nullable instancetype)initStoreRequestWithDsn:(SentryDsn *)dsn
-                                          andData:(NSData *)data
-                                 didFailWithError:(NSError *_Nullable *_Nullable)error;
-
 - (_Nullable instancetype)initEnvelopeRequestWithDsn:(SentryDsn *)dsn
                                              andData:(NSData *)data
                                     didFailWithError:(NSError *_Nullable *_Nullable)error;

Tests/SentryTests/Networking/SentryDsnTests.m

@@ -20,45 +20,6 @@ - (void)testMissingUsernamePassword
     XCTAssertNil(options);
 }
 
-- (void)testDsnHeaderUsernameAndPassword
-{
-    NSError *error = nil;
-    SentryDsn *dsn = [[SentryDsn alloc] initWithString:@"https://username:password@sentry.io/1"
-                                      didFailWithError:&error];
-    SentryNSURLRequest *request = [[SentryNSURLRequest alloc] initStoreRequestWithDsn:dsn
-                                                                              andData:[NSData data]
-                                                                     didFailWithError:&error];
-
-    NSString *authHeader =
-        [[NSString alloc] initWithFormat:@"Sentry "
-                                         @"sentry_version=7,sentry_client=sentry.cocoa/"
-                                         @"%@,sentry_key=username,sentry_"
-                                         @"secret=password",
-            SentryMeta.versionString];
-
-    XCTAssertEqualObjects(request.allHTTPHeaderFields[@"X-Sentry-Auth"], authHeader);
-    XCTAssertNil(error);
-}
-
-- (void)testDsnHeaderUsername
-{
-    NSError *error = nil;
-    SentryDsn *dsn = [[SentryDsn alloc] initWithString:@"https://username@sentry.io/1"
-                                      didFailWithError:&error];
-    SentryNSURLRequest *request = [[SentryNSURLRequest alloc] initStoreRequestWithDsn:dsn
-                                                                              andData:[NSData data]
-                                                                     didFailWithError:&error];
-
-    NSString *authHeader =
-        [[NSString alloc] initWithFormat:@"Sentry "
-                                         @"sentry_version=7,sentry_client=sentry.cocoa/"
-                                         @"%@,sentry_key=username",
-            SentryMeta.versionString];
-
-    XCTAssertEqualObjects(request.allHTTPHeaderFields[@"X-Sentry-Auth"], authHeader);
-    XCTAssertNil(error);
-}
-
 - (void)testMissingScheme
 {
     NSError *error = nil;

Tests/SentryTests/SentryNSURLRequestTests.swift

@@ -15,19 +15,8 @@ class SentryNSURLRequestTests: XCTestCase {
         XCTAssert(string.hasSuffix("/envelope/"))
     }
 
-    func testRequestWithStoreEndpoint() throws {
-        let request = try! SentryNSURLRequest(storeRequestWith: SentryNSURLRequestTests.dsn(), andData: Data())
-        let string = try XCTUnwrap(request.url?.absoluteString as? NSString)
-        XCTAssert(string.hasSuffix("/store/"))
-    }
-    
     func testRequestWithEnvelopeEndpoint_hasUserAgentWithSdkNameAndVersion() {
         let request = try! SentryNSURLRequest(envelopeRequestWith: SentryNSURLRequestTests.dsn(), andData: Data())
         XCTAssertEqual(request.allHTTPHeaderFields?["User-Agent"], "\(SentryMeta.sdkName)/\(SentryMeta.versionString)")
     }
-    
-    func testRequestWithStoreEndpoint_hasUserAgentWithSdkNameAndVersion() {
-        let request = try! SentryNSURLRequest(storeRequestWith: SentryNSURLRequestTests.dsn(), andData: Data())
-        XCTAssertEqual(request.allHTTPHeaderFields?["User-Agent"], "\(SentryMeta.sdkName)/\(SentryMeta.versionString)")
-    }
 }