test: shared sdk wrapper other platforms#5085
test: shared sdk wrapper other platforms#5085armcknight wants to merge 9 commits intoarmcknight/test/share-sdk-wrapperfrom
Conversation
armcknight
force-pushed
the
armcknight/test/share-sdk-wrapper
branch
from
78e25e9 to
3112778
Compare
armcknight
left a comment
armcknight
left a comment
There was a problem hiding this comment.
Just a couple things I noticed as I went through this that I think are beneficial right off the bat
| if let sessionTrackingIntervalMillis = env["--io.sentry.sessionTrackingIntervalMillis"] { | ||
| options.sessionTrackingIntervalMillis = UInt((sessionTrackingIntervalMillis as NSString).integerValue) | ||
| } else { | ||
| options.sessionTrackingIntervalMillis = 5_000 |
There was a problem hiding this comment.
This wasn't set for many of the sample apps as the default
| #endif // os(iOS) || os(tvOS) || targetEnvironment(macCatalyst) || os(visionOS) | ||
|
|
||
| #if os(macOS) | ||
| options.enableUncaughtNSExceptionReporting = true |
There was a problem hiding this comment.
This was only set for macOS-SwiftUI but not macOS-Swift
| return scope | ||
| } | ||
|
|
||
| options.experimental.enableFileManagerSwizzling = !args.contains("--disable-filemanager-swizzling") |
There was a problem hiding this comment.
This launch arg introduced in #4634 wasn't actually configured in any of our shared schemas, I shared it in the upstream PR at https://github.com/getsentry/sentry-cocoa/pull/5076/files#diff-384a7a6c421086af40fa69500d57db0f5122e16c6c2753bf6bbf60447e2a3c06R105 so now all sample apps can use it
armcknight
force-pushed
the
armcknight/test/share-sdk-wrapper
branch
from
3112778 to
783f991
Compare
armcknight
force-pushed
the
armcknight/test/shared-sdk-wrapper-other-platforms
branch
from
22f774b to
4933865
Compare
…/shared-sdk-wrapper-other-platforms
…/shared-sdk-wrapper-other-platforms
…/shared-sdk-wrapper-other-platforms
|
This will significantly change after moving to xcodegen, so will redo in a new PR when the time comes. |
armcknight
deleted the
armcknight/test/shared-sdk-wrapper-other-platforms
branch
1 participant
Following on #5076 and #5077, switch the remaining sample apps implemented in Swift on other platforms to use the shared SDK wrapper.
#skip-changelog