Skip to content

Convert SentryGeo to Swift #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Convert SentryGeo to Swift #5391

wants to merge 1 commit into from

Conversation

noahsmartin
Copy link
Contributor

#skip-changelog

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 8.309%. Comparing base (603fec8) to head (470a124).

Files with missing lines Patch % Lines
Sources/Swift/Protocol/Codable/SentryGeo.swift 0.000% 46 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (603fec8) and HEAD (470a124). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (603fec8) HEAD (470a124)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5391        +/-   ##
=============================================
- Coverage   86.046%   8.309%   -77.738%     
=============================================
  Files          397      364        -33     
  Lines        34594    26753      -7841     
  Branches     14980       57     -14923     
=============================================
- Hits         29767     2223     -27544     
- Misses        4787    24530     +19743     
+ Partials        40        0        -40     
Files with missing lines Coverage Δ
Sources/Sentry/SentryUser.m 0.000% <ø> (-96.179%) ⬇️
Sources/Swift/Protocol/Codable/SentryGeo.swift 0.000% <0.000%> (ø)

... and 388 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603fec8...470a124. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 10, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.72 ms 1242.84 ms 23.11 ms
Size 23.75 KiB 844.42 KiB 820.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9ce2a01 1237.02 ms 1263.69 ms 26.67 ms
e76c341 1235.48 ms 1246.24 ms 10.77 ms
4350d44 1228.75 ms 1246.75 ms 18.00 ms
0cb9644 1228.11 ms 1245.35 ms 17.24 ms
0204c72 1230.35 ms 1242.04 ms 11.69 ms
ed68562 1229.16 ms 1248.74 ms 19.58 ms
bb7da60 1231.80 ms 1252.65 ms 20.85 ms
bd05478 1233.82 ms 1255.56 ms 21.74 ms
16450b8 1196.33 ms 1217.26 ms 20.93 ms
2deb275 1215.63 ms 1232.45 ms 16.82 ms

App size

Revision Plain With Sentry Diff
9ce2a01 23.76 KiB 861.22 KiB 837.46 KiB
e76c341 22.31 KiB 775.17 KiB 752.85 KiB
4350d44 21.58 KiB 629.82 KiB 608.24 KiB
0cb9644 22.30 KiB 819.10 KiB 796.80 KiB
0204c72 21.58 KiB 540.04 KiB 518.46 KiB
ed68562 22.84 KiB 403.24 KiB 380.39 KiB
bb7da60 21.58 KiB 697.84 KiB 676.25 KiB
bd05478 20.76 KiB 432.33 KiB 411.57 KiB
16450b8 22.85 KiB 410.98 KiB 388.13 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB

Previous results on branch: convertSentryGeoSwift

Startup times

Revision Plain With Sentry Diff
53a0f75 1216.68 ms 1246.35 ms 29.67 ms

App size

Revision Plain With Sentry Diff
53a0f75 23.75 KiB 844.67 KiB 820.92 KiB

@noahsmartin noahsmartin force-pushed the convertSentryGeoSwift branch from c028abd to 470a124 Compare June 10, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant