-
-
Notifications
You must be signed in to change notification settings - Fork 361
chore: Bump versions #5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Bump versions #5443
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5443 +/- ##
=============================================
+ Coverage 85.787% 85.798% +0.010%
=============================================
Files 399 399
Lines 34773 34770 -3
Branches 14784 14781 -3
=============================================
+ Hits 29831 29832 +1
+ Misses 4899 4896 -3
+ Partials 43 42 -1 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7206904 | 1221.86 ms | 1242.85 ms | 21.00 ms |
79f3fcf | 1216.39 ms | 1236.21 ms | 19.82 ms |
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
6604dbb | 1248.35 ms | 1256.14 ms | 7.79 ms |
f273312 | 1242.92 ms | 1259.78 ms | 16.86 ms |
ed49f0c | 1245.67 ms | 1261.15 ms | 15.48 ms |
20a828b | 1211.33 ms | 1228.00 ms | 16.67 ms |
7b032f3 | 1232.24 ms | 1257.29 ms | 25.05 ms |
742d4b6 | 1230.41 ms | 1247.23 ms | 16.83 ms |
c1db61e | 1228.65 ms | 1245.86 ms | 17.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7206904 | 23.76 KiB | 861.24 KiB | 837.48 KiB |
79f3fcf | 23.75 KiB | 841.01 KiB | 817.26 KiB |
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
6604dbb | 22.84 KiB | 402.56 KiB | 379.72 KiB |
f273312 | 21.58 KiB | 707.35 KiB | 685.77 KiB |
ed49f0c | 21.58 KiB | 632.13 KiB | 610.55 KiB |
20a828b | 21.58 KiB | 670.99 KiB | 649.41 KiB |
7b032f3 | 22.31 KiB | 819.58 KiB | 797.27 KiB |
742d4b6 | 21.58 KiB | 546.20 KiB | 524.62 KiB |
c1db61e | 22.30 KiB | 851.56 KiB | 829.26 KiB |
I think it's acceptable to do this even in a non major because you have to use Xcode 16 to submit apps and you now can't use iOS 11 anymore as the min OS version. We only must clearly point this out in the changelog. |
6c5af05
to
98c4b35
Compare
98c4b35
to
05221e0
Compare
We're going to wait until the next release (8.53.0) is out and then merge this |
This should be a breaking change that shouldn't ship until V9. ETA because I just saw Philipp's comment: two considerations:
|
Yes, you must use Xcode 16 now to submit to the app store #5443 (comment) |
Ah, sorry, I thought this was due to Xcode 26. If this is a warning in Xcode 16, is this already breaking customer workflows in any way? Like, does it show up as an error in any way by some combination of a package manager and settings like treating warnings as errors? Or does it actually prevent submissions to the app store? Has this been reported by anyone? Essentially: what is the urgency here? The thing is that this has the potential to break some peoples' workflows, which is why I advocate to make this a major revision. You can always rationalize something as just a bugfix, but if it breaks contracts, it breaks contracts, there is no rationalizing away CI failures. We should just be up front about that by reporting it in the standardized way with semver. This is why I proposed a while ago to bump these minimum versions every fall with the new GAs of Xcode in our own major revisions in lockstep with Xcode. That can has already been kicked down the road for years, despite my prodding, in the name of backwards compatibility, and now we want to break that same compatibility in a poorly communicated fashion. I think we can wait a bit longer and do it the right way. |
Those are valid points, @armcknight. So let's do it properly and do this with a major release. It's worth noting that we don't have to tackle all major items in #2946 for v9. Doing the most important ones is also acceptable and save some for v10. |
I agree with @armcknight and @philipphofmann here - we should prioritise shipping v9 and bump the versions as part of that |
Update the minimum SDK versions to the earliest versions still supported by Xcode. This resolves a warning in Xcode that we are targeting a version that is not supported by Xcode.