Skip to content

[WIP] Request manager in Swift #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

noahsmartin
Copy link
Contributor

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@noahsmartin noahsmartin force-pushed the requestManagerSwift branch from b63e64f to c513f0d Compare June 21, 2025 03:03
@noahsmartin noahsmartin force-pushed the requestManagerSwift branch from c513f0d to 632ca2c Compare June 21, 2025 03:09
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 8.305%. Comparing base (95cfd20) to head (632ca2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/Swift/Tools/SentryQueueableRequestManager.swift 73.913% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (95cfd20) and HEAD (632ca2c). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (95cfd20) HEAD (632ca2c)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5452        +/-   ##
=============================================
- Coverage   86.221%   8.305%   -77.916%     
=============================================
  Files          399      367        -32     
  Lines        34647    26812      -7835     
  Branches     14983       57     -14926     
=============================================
- Hits         29873     2227     -27646     
- Misses        4726    24585     +19859     
+ Partials        48        0        -48     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySpotlightTransport.m 0.000% <ø> (-79.311%) ⬇️
Sources/Sentry/SentryTransportFactory.m 81.578% <ø> (-18.422%) ⬇️
...es/Swift/Tools/SentryQueueableRequestManager.swift 73.913% <73.913%> (ø)

... and 390 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cfd20...632ca2c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.65 ms 1241.02 ms 28.37 ms
Size 23.75 KiB 847.77 KiB 824.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c5232ea 1226.06 ms 1246.57 ms 20.50 ms
464117d 1240.46 ms 1252.91 ms 12.45 ms
94e1968 1230.22 ms 1253.33 ms 23.11 ms
3ea21f5 1250.80 ms 1258.88 ms 8.08 ms
b1783fd 1216.67 ms 1238.75 ms 22.08 ms
794f87f 1225.78 ms 1243.46 ms 17.68 ms
17afc4b 1228.94 ms 1251.10 ms 22.16 ms
6e31b7c 1230.80 ms 1246.29 ms 15.49 ms
25e00aa 1236.98 ms 1250.98 ms 14.00 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms

App size

Revision Plain With Sentry Diff
c5232ea 22.85 KiB 413.98 KiB 391.13 KiB
464117d 21.58 KiB 705.40 KiB 683.82 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
3ea21f5 22.84 KiB 402.63 KiB 379.78 KiB
b1783fd 22.31 KiB 818.59 KiB 796.28 KiB
794f87f 20.76 KiB 401.37 KiB 380.61 KiB
17afc4b 20.76 KiB 436.25 KiB 415.49 KiB
6e31b7c 21.58 KiB 614.65 KiB 593.07 KiB
25e00aa 23.76 KiB 821.43 KiB 797.67 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB

@noahsmartin noahsmartin changed the title Request manager in Swift [WIP] Request manager in Swift Jun 21, 2025
@philprime
Copy link
Member

Jumping in here even though it is still in draft, what made you rewrite the file in Swift?

@ohwhen
Copy link

ohwhen commented Jul 13, 2025

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants