-
-
Notifications
You must be signed in to change notification settings - Fork 362
[WIP] Request manager in Swift #5452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b63e64f
to
c513f0d
Compare
c513f0d
to
632ca2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5452 +/- ##
=============================================
- Coverage 86.221% 8.305% -77.916%
=============================================
Files 399 367 -32
Lines 34647 26812 -7835
Branches 14983 57 -14926
=============================================
- Hits 29873 2227 -27646
- Misses 4726 24585 +19859
+ Partials 48 0 -48
... and 390 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c5232ea | 1226.06 ms | 1246.57 ms | 20.50 ms |
464117d | 1240.46 ms | 1252.91 ms | 12.45 ms |
94e1968 | 1230.22 ms | 1253.33 ms | 23.11 ms |
3ea21f5 | 1250.80 ms | 1258.88 ms | 8.08 ms |
b1783fd | 1216.67 ms | 1238.75 ms | 22.08 ms |
794f87f | 1225.78 ms | 1243.46 ms | 17.68 ms |
17afc4b | 1228.94 ms | 1251.10 ms | 22.16 ms |
6e31b7c | 1230.80 ms | 1246.29 ms | 15.49 ms |
25e00aa | 1236.98 ms | 1250.98 ms | 14.00 ms |
4c00f8c | 1231.62 ms | 1237.76 ms | 6.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c5232ea | 22.85 KiB | 413.98 KiB | 391.13 KiB |
464117d | 21.58 KiB | 705.40 KiB | 683.82 KiB |
94e1968 | 21.58 KiB | 614.74 KiB | 593.15 KiB |
3ea21f5 | 22.84 KiB | 402.63 KiB | 379.78 KiB |
b1783fd | 22.31 KiB | 818.59 KiB | 796.28 KiB |
794f87f | 20.76 KiB | 401.37 KiB | 380.61 KiB |
17afc4b | 20.76 KiB | 436.25 KiB | 415.49 KiB |
6e31b7c | 21.58 KiB | 614.65 KiB | 593.07 KiB |
25e00aa | 23.76 KiB | 821.43 KiB | 797.67 KiB |
4c00f8c | 20.76 KiB | 419.62 KiB | 398.86 KiB |
Jumping in here even though it is still in draft, what made you rewrite the file in Swift? |
👀 |
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.#skip-changelog