Skip to content

ref: Convert SentrySdkInfo to Swift #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

noahsmartin
Copy link
Contributor

Convert this file to Swift

#skip-changelog

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

❌ Patch coverage is 0% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.711%. Comparing base (1bf432b) to head (579b1e8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% 88 Missing ⚠️
Sources/Sentry/SentryClient.m 0.000% 3 Missing ⚠️
Sources/Sentry/SentryEnvelope.m 0.000% 3 Missing ⚠️
...ources/Swift/Core/Helper/SentryExtraPackages.swift 0.000% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1bf432b) and HEAD (579b1e8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (1bf432b) HEAD (579b1e8)
5 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5481        +/-   ##
=============================================
- Coverage   86.693%   7.711%   -78.982%     
=============================================
  Files          424      392        -32     
  Lines        36643    34936      -1707     
  Branches     17320    13817      -3503     
=============================================
- Hits         31767     2694     -29073     
- Misses        4830    32231     +27401     
+ Partials        46       11        -35     
Files with missing lines Coverage Δ
Sources/Sentry/SentryHub.m 16.173% <ø> (-81.914%) ⬇️
Sources/Sentry/SentrySerialization.m 0.000% <ø> (-98.819%) ⬇️
...ources/Swift/Core/Helper/SentryExtraPackages.swift 0.000% <0.000%> (-95.239%) ⬇️
Sources/Sentry/SentryClient.m 8.981% <0.000%> (-89.539%) ⬇️
Sources/Sentry/SentryEnvelope.m 0.000% <0.000%> (-89.321%) ⬇️
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% <0.000%> (ø)

... and 403 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf432b...579b1e8. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jun 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.76 ms 1263.91 ms 23.16 ms
Size 23.75 KiB 927.79 KiB 904.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
80a5166 1224.49 ms 1251.29 ms 26.80 ms
82f60cf 1218.65 ms 1238.52 ms 19.87 ms
f92cfa9 1217.94 ms 1240.06 ms 22.12 ms
63ac649 1192.10 ms 1216.78 ms 24.68 ms
1936411 1231.51 ms 1253.27 ms 21.76 ms
fae97e5 1229.20 ms 1256.27 ms 27.06 ms
c2982e7 1223.92 ms 1242.86 ms 18.94 ms
56f9cc6 1209.47 ms 1236.84 ms 27.37 ms
018037b 1209.31 ms 1228.33 ms 19.03 ms

App size

Revision Plain With Sentry Diff
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
80a5166 23.75 KiB 904.53 KiB 880.78 KiB
82f60cf 23.75 KiB 913.63 KiB 889.88 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.63 KiB
63ac649 23.75 KiB 855.38 KiB 831.63 KiB
1936411 23.74 KiB 913.39 KiB 889.64 KiB
fae97e5 23.75 KiB 912.37 KiB 888.62 KiB
c2982e7 23.75 KiB 911.62 KiB 887.87 KiB
56f9cc6 23.75 KiB 913.63 KiB 889.88 KiB
018037b 23.75 KiB 867.16 KiB 843.41 KiB

Previous results on branch: convertSentrySdkInfo

Startup times

Revision Plain With Sentry Diff
ab9fe41 1202.86 ms 1256.56 ms 53.71 ms
e48f485 1211.18 ms 1233.71 ms 22.53 ms

App size

Revision Plain With Sentry Diff
ab9fe41 23.75 KiB 857.88 KiB 834.13 KiB
e48f485 23.75 KiB 857.68 KiB 833.93 KiB

@noahsmartin noahsmartin force-pushed the convertSentrySdkInfo branch 2 times, most recently from 30e5a2c to 443be4f Compare June 25, 2025 02:13
@noahsmartin noahsmartin marked this pull request as draft June 25, 2025 02:49
@noahsmartin noahsmartin force-pushed the convertSentrySdkInfo branch 3 times, most recently from c95de92 to 18a5ec2 Compare August 15, 2025 17:44
@noahsmartin noahsmartin force-pushed the convertSentrySdkInfo branch from 18a5ec2 to 579b1e8 Compare August 15, 2025 17:54
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentrySerialization.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant