Skip to content

ref: Convert SentrySdkInfo to Swift #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

noahsmartin
Copy link
Contributor

Convert this file to Swift

#skip-changelog

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 8.248%. Comparing base (d38165b) to head (443be4f).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% 70 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d38165b) and HEAD (443be4f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d38165b) HEAD (443be4f)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5481        +/-   ##
=============================================
- Coverage   86.254%   8.248%   -78.007%     
=============================================
  Files          401      369        -32     
  Lines        34863    26877      -7986     
  Branches     15134       57     -15077     
=============================================
- Hits         30071     2217     -27854     
- Misses        4751    24660     +19909     
+ Partials        41        0        -41     
Files with missing lines Coverage Δ
Sources/Sentry/SentryClient.m 9.743% <ø> (-88.723%) ⬇️
Sources/Sentry/SentryEnvelope.m 0.000% <ø> (-89.321%) ⬇️
Sources/Sentry/SentrySerialization.m 0.000% <ø> (-99.164%) ⬇️
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% <0.000%> (ø)

... and 391 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38165b...443be4f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1202.86 ms 1256.56 ms 53.71 ms
Size 23.75 KiB 857.88 KiB 834.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2b02431 1229.63 ms 1248.98 ms 19.35 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms

App size

Revision Plain With Sentry Diff
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB

Previous results on branch: convertSentrySdkInfo

Startup times

Revision Plain With Sentry Diff
e48f485 1211.18 ms 1233.71 ms 22.53 ms

App size

Revision Plain With Sentry Diff
e48f485 23.75 KiB 857.68 KiB 833.93 KiB

@noahsmartin noahsmartin force-pushed the convertSentrySdkInfo branch from 30e5a2c to 443be4f Compare June 25, 2025 02:13
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentrySerialization.m

@noahsmartin noahsmartin marked this pull request as draft June 25, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant