ci: remove simulator boot script #5557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann,
philprime,
noahsmartin,
trevor-e,
itaybre and
NicoHinderling
as code owners
noahsmartin
approved these changes
Jul 2, 2025
armcknight
force-pushed
the
armcknight/ci/remove-simulator-boot-script
branch
from
e1adcdd to
60ed58e
Compare
|
Hmm, appears it actually is still needed. the ci workflow failed due to no booted devices: https://github.com/getsentry/sentry-cocoa/actions/runs/16033550566/job/45239750902#step:6:539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while preparing #5556 that this script is only called for a single UI test. It was originally introduced in #5031 and then mostly removed in #5093 (even though logic was added to the script, maybe this was some kind of mistake) and also one more instance was removed in https://github.com/getsentry/sentry-cocoa/pull/5398/files.
Unless all the other UI tests have gotten worse since it was removed from them, this indicates to me that it isn't really necessary any longer.
#skip-changelog