Skip to content

feat(v9): Remove profiling APIs deprecated in V9 #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noahsmartin
Copy link
Contributor

WIP

#skip-changelog

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5292991

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.540%. Comparing base (736bcfb) to head (5292991).

Files with missing lines Patch % Lines
...entry/Profiling/SentryProfiledTracerConcurrency.mm 71.428% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5616       +/-   ##
=============================================
+ Coverage   86.535%   86.540%   +0.005%     
=============================================
  Files          417       417               
  Lines        35427     35463       +36     
  Branches     15335     15328        -7     
=============================================
+ Hits         30657     30690       +33     
- Misses        4728      4732        +4     
+ Partials        42        41        -1     
Files with missing lines Coverage Δ
Sources/Sentry/Profiling/SentryLaunchProfiling.m 96.885% <100.000%> (+0.077%) ⬆️
Sources/Sentry/SentryHub.m 99.113% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 98.805% <100.000%> (+0.012%) ⬆️
Sources/Sentry/SentryProfiler.mm 88.888% <100.000%> (-1.473%) ⬇️
Sources/Sentry/SentrySDK.m 88.833% <100.000%> (+0.111%) ⬆️
Sources/Sentry/SentrySampling.m 94.520% <100.000%> (ø)
Sources/Sentry/SentrySpan.m 97.701% <100.000%> (+0.072%) ⬆️
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <100.000%> (ø)
...entry/Profiling/SentryProfiledTracerConcurrency.mm 92.035% <71.428%> (-0.725%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736bcfb...5292991. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.08 ms 1261.06 ms 23.98 ms
Size 23.75 KiB 891.02 KiB 867.27 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d637379 1226.43 ms 1250.77 ms 24.34 ms
736bcfb 1229.86 ms 1249.59 ms 19.73 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
8e3a42f 1222.90 ms 1245.67 ms 22.77 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
b045d0a 1227.48 ms 1252.22 ms 24.75 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
aa98fe8 1227.69 ms 1253.18 ms 25.50 ms

App size

Revision Plain With Sentry Diff
d637379 23.75 KiB 855.38 KiB 831.63 KiB
736bcfb 23.74 KiB 891.02 KiB 867.28 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
8e3a42f 23.75 KiB 880.06 KiB 856.31 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
b045d0a 23.75 KiB 880.21 KiB 856.46 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
aa98fe8 23.75 KiB 891.01 KiB 867.26 KiB

Previous results on branch: removeDeprecatedAPIsV9

Startup times

Revision Plain With Sentry Diff
e88d44d 1229.16 ms 1249.15 ms 19.99 ms
91ea5c6 1230.62 ms 1254.62 ms 24.01 ms
fc933bd 1227.86 ms 1251.80 ms 23.94 ms
c611745 1229.12 ms 1251.39 ms 22.26 ms

App size

Revision Plain With Sentry Diff
e88d44d 23.75 KiB 880.46 KiB 856.71 KiB
91ea5c6 23.75 KiB 891.02 KiB 867.27 KiB
fc933bd 23.75 KiB 880.32 KiB 856.57 KiB
c611745 23.75 KiB 880.45 KiB 856.69 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedAPIsV9 branch 7 times, most recently from fd98350 to d7d6f6e Compare July 15, 2025 01:58
@noahsmartin noahsmartin force-pushed the removeDeprecatedAPIsV9 branch from d7d6f6e to 5292991 Compare July 15, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant