Do not report cached events as lost #4575

adinauer · 2025-07-29T15:04:41Z

📜 Description

Do not report cached events as lost

💡 Motivation and Context

Fixes #4568

💚 How did you test it?

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer · 2025-07-29T15:04:59Z

Do not report cached events as lost #4575 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-07-29T15:05:05Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

github-actions · 2025-07-29T15:19:40Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	445.50 ms	446.58 ms	1.08 ms
Size	1.58 MiB	2.09 MiB	522.31 KiB

Previous results on branch: 07-29-do_not_report_cached_events_as_lost

Startup times

Revision	Plain	With Sentry	Diff
`4bd0f22`	395.69 ms	448.04 ms	52.35 ms
`972727c`	393.16 ms	434.53 ms	41.37 ms
`d4dcd6e`	399.34 ms	421.18 ms	21.84 ms
`020c051`	431.22 ms	470.64 ms	39.42 ms

App size

Revision	Plain	With Sentry	Diff
`4bd0f22`	1.58 MiB	2.09 MiB	522.32 KiB
`972727c`	1.58 MiB	2.09 MiB	519.50 KiB
`d4dcd6e`	1.58 MiB	2.09 MiB	522.31 KiB
`020c051`	1.58 MiB	2.09 MiB	519.63 KiB

* e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

github-actions · 2025-07-29T16:14:08Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

adinauer · 2025-07-30T14:57:57Z

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

@@ -268,7 +268,7 @@ public void run() {
      TransportResult result = this.failedResult;

      envelope.getHeader().setSentAt(null);
-      envelopeCache.store(envelope, hint);
+      boolean cached = envelopeCache.storeEnvelope(envelope, hint);


Since envelopes that were cached previously have a no-op envelope cache here inEnvelopeSender, this will be false for envelopes sent from cache.

github-actions · 2025-07-30T14:59:19Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

romtsn · 2025-08-01T11:13:28Z

sentry/src/main/java/io/sentry/cache/IEnvelopeCache.java

  void store(@NotNull SentryEnvelope envelope, @NotNull Hint hint);

+  default boolean storeEnvelope(@NotNull SentryEnvelope envelope, @NotNull Hint hint) {


could you also explicitly implement it in AndroidEnvelopeCache? I recall there were some issues with desugaring on Unity, where it would crash with NoSuchMethodError for default methods in core sentry

romtsn · 2025-08-01T11:22:50Z

sentry/src/main/java/io/sentry/cache/IEnvelopeCache.java

  void store(@NotNull SentryEnvelope envelope, @NotNull Hint hint);

+  default boolean storeEnvelope(@NotNull SentryEnvelope envelope, @NotNull Hint hint) {
+    store(envelope, hint);
+    return true;


I think we should actually return false in case an envelope couldn't be stored here, wdyt? Could be because of no storage space, for example.

romtsn

I left two comments that I think need to be addressed before merging this:

Implement storeEnvelope in AndroidEnvelopeCache
Return false for the case where an envelope could not be stored due to FileSystem issues

…PC calls (#4560)

As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files

* fix(android): Remove unused method * Update Changelog

#skip-changelog ## 📜 Description  Add rules file for documenting SDK offline behaviour ## 💡 Motivation and Context   Should help speed up AI reasoning about the SDK offline/retry behaviour. ## 💚 How did you test it? ## 📝 Checklist  - [ ] I added tests to verify the changes. - [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled. - [ ] I updated the docs if needed. - [ ] I updated the wizard if needed. - [ ] Review from the native team if needed. - [ ] No breaking change or entry added to the changelog. - [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs. ## 🔮 Next steps

…4562)

* fix: sentry-androi-ndk proguard rule keeps all native class * docs: update CHANGELOG * fix: update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

* perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

* fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks

…acks when launched with background importance (#4579)

…red on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback

github-actions · 2025-08-08T09:31:29Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

github-actions · 2025-08-08T11:37:25Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

github-actions · 2025-08-08T11:58:54Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

cursor · 2025-08-08T12:04:47Z

sentry/src/main/java/io/sentry/cache/IEnvelopeCache.java

  default void store(@NotNull SentryEnvelope envelope) {
-    store(envelope, new Hint());
+    storeEnvelope(envelope, new Hint());


Bug: Cache Store Failure Masking

The default implementation of IEnvelopeCache.storeEnvelope() always returns true, even if a custom implementation of the deprecated store(SentryEnvelope, Hint) method fails silently. This incorrectly indicates successful caching. Furthermore, the deprecated store(SentryEnvelope) method calls storeEnvelope() but ignores its boolean return value, masking storage failures for callers still using this API.

We have to maintain backward compatibility and thus cannot replace the method directly. We are overriding storeEnvelope in both EnvelopeCache and AndroidEnvelopeCache to avoid this problem.

Do not report cached events as lost

0d0c782

adinauer commented Jul 30, 2025

View reviewed changes

Merge branch 'main' into 07-29-do_not_report_cached_events_as_lost

a320001

adinauer marked this pull request as ready for review July 30, 2025 14:59

adinauer requested review from romtsn, stefanosiano, markushi and lcian as code owners July 30, 2025 14:59

This comment was marked as outdated.

Sign in to view

romtsn reviewed Aug 1, 2025

View reviewed changes

romtsn approved these changes Aug 1, 2025

View reviewed changes

getsentry-bot and others added 12 commits August 8, 2025 11:26

release: 8.18.0

b435169

ref(replay): Use main thread to schedule capture (#4542)

c1cee9b

perf(connectivity): Cache network capabilities and status to reduce I…

59250c4

…PC calls (#4560)

fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561)

270a4c3

fix(ci): remove obsolete NDK debug symbols (#4581)

039ffbc

As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files

fix(android): Remove unused method (#4585)

3fd31b6

* fix(android): Remove unused method * Update Changelog

perf(connectivity): Have only one NetworkCallback active at a time (#…

e45908a

…4562)

fix(scripts): update-gradle script set-version (#4591)

63b9d7b

fix(sqlite): Fix abstract method error (#4597)

29f057b

* fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks

romtsn and others added 5 commits August 8, 2025 11:26

perf(integrations): Do not register for SystemEvents and NetworkCallb…

d4ba02b

…acks when launched with background importance (#4579)

fix(android): Ensure frame metrics listeners are registered/unregiste…

4425a1b

…red on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback

perf(executor): Prewarm SentryExecutorService (#4606)

2c7271a

review feedback

644dcd8

changelog

78bb822

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into 07-29-do_not_report_cached_events_as_lost

c1a6766

pass through whether cache stored in AndroidEnvelopeCache + test

9ac34bb

getsentry-bot and others added 2 commits August 8, 2025 11:38

Format code

b4ac53c

Merge branch 'main' into 07-29-do_not_report_cached_events_as_lost

ffd313f

cursor bot reviewed Aug 8, 2025

View reviewed changes

adinauer merged commit e2b7f44 into main Aug 8, 2025
37 checks passed

adinauer deleted the 07-29-do_not_report_cached_events_as_lost branch August 8, 2025 12:35

		void store(@NotNull SentryEnvelope envelope, @NotNull Hint hint);

		default boolean storeEnvelope(@NotNull SentryEnvelope envelope, @NotNull Hint hint) {

Uh oh!

Do not report cached events as lost #4575

Do not report cached events as lost #4575

Uh oh!

Conversation

adinauer commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

adinauer commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: 07-29-do_not_report_cached_events_as_lost

Startup times

App size

Uh oh!

github-actions bot commented Jul 29, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

adinauer Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 30, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

This comment was marked as outdated.

Uh oh!

romtsn Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

romtsn Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

romtsn left a comment • edited by adinauer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Aug 8, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Aug 8, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Aug 8, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

cursor bot Aug 8, 2025

Choose a reason for hiding this comment

Bug: Cache Store Failure Masking

Uh oh!

adinauer Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adinauer commented Jul 29, 2025 •

edited

Loading

github-actions bot commented Jul 29, 2025 •

edited

Loading

romtsn left a comment •

edited by adinauer

Loading