Skip to content

Conversation

@Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Nov 19, 2025

Adds rate limiting for profile and adds mapping from check_in => monitor to properly handle check_in rate limits.

Definitions for data categories are located here: https://develop.sentry.dev/sdk/expected-features/rate-limiting/#definitions

closes PHP-54

@linear
Copy link

linear bot commented Nov 19, 2025

@Litarnus Litarnus marked this pull request as ready for review November 19, 2025 16:00
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this as TODO to the agent. Wondering if it's worth refactoring a bit so we can have a isRateLimited($event) instead of doing it like this so we can re-use this logic in the agent.

@Litarnus
Copy link
Contributor Author

Also added this as TODO to the agent. Wondering if it's worth refactoring a bit so we can have a isRateLimited($event) instead of doing it like this so we can re-use this logic in the agent.

I was thinking about this but profiles need to be removed from transaction and I didn't want to introduce mutation in the RateLimiter.
That said we should look into refactoring to use it in both places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants