Correctly return Job#perform's return value (#1667)

Author: st0012

sentry-rails/lib/sentry/rails/active_job.rb

@@ -24,9 +24,11 @@ def capture_and_reraise_with_sentry(scope, &block)
 
         scope.set_span(transaction) if transaction
 
-        block.call
+        return_value = block.call
 
         finish_sentry_transaction(transaction, 200)
+
+        return_value
       rescue Exception => e # rubocop:disable Lint/RescueException
         finish_sentry_transaction(transaction, 500)
 

sentry-rails/spec/sentry/rails/activejob_spec.rb

@@ -1,6 +1,12 @@
 require "spec_helper"
 require "active_job/railtie"
 
+class NormalJob < ActiveJob::Base
+  def perform
+    "foo"
+  end
+end
+
 class FailedJob < ActiveJob::Base
   self.logger = nil
 
@@ -47,6 +53,10 @@ def rescue_callback(error)
   it "runs job" do
     expect { FailedJob.perform_now }.to raise_error(FailedJob::TestError)
   end
+
+  it "returns #perform method's return value" do
+    expect(NormalJob.perform_now).to eq("foo")
+  end
 end
 
 RSpec.describe "ActiveJob integration" do
@@ -62,6 +72,10 @@ def rescue_callback(error)
     Sentry.get_current_client.transport
   end
 
+  it "returns #perform method's return value" do
+    expect(NormalJob.perform_now).to eq("foo")
+  end
+
   it "adds useful context to extra" do
     expect { FailedJob.perform_now }.to raise_error(FailedJob::TestError)