Fix clutter in test output

Author: nateberkopec

lib/raven/cli.rb

@@ -1,29 +1,32 @@
 module Raven
   class CLI
-    def self.test(dsn = nil)
-      require 'logger'
+    def self.test(dsn = nil, silent = false)
+      if silent
+        Raven.configuration.logger = ::Logger.new(nil)
+      else
+        logger = ::Logger.new(STDOUT)
+        logger.level = ::Logger::ERROR
+        logger.formatter = proc do |_severity, _datetime, _progname, msg|
+          "-> #{msg}\n"
+        end
 
-      logger = ::Logger.new(STDOUT)
-      logger.level = ::Logger::ERROR
-      logger.formatter = proc do |_severity, _datetime, _progname, msg|
-        "-> #{msg}\n"
+        Raven.configuration.logger = logger
       end
 
-      Raven.configuration.logger = logger
       Raven.configuration.timeout = 5
       Raven.configuration.dsn = dsn if dsn
 
       # wipe out env settings to ensure we send the event
       unless Raven.configuration.capture_in_current_environment?
         env_name = Raven.configuration.environments.pop || 'production'
-        puts "Setting environment to #{env_name}"
+        Raven.logger.debug "Setting environment to #{env_name}"
         Raven.configuration.current_environment = env_name
       end
 
       Raven.configuration.verify!
 
-      puts "Sending a test event:"
-      puts ""
+      Raven.logger.debug "Sending a test event:"
+      Raven.logger.debug ""
 
       begin
         1 / 0
@@ -33,24 +36,24 @@ def self.test(dsn = nil)
 
       if evt && !(evt.is_a? Thread)
         if evt.is_a? Hash
-          puts "-> event ID: #{evt[:event_id]}"
+          Raven.logger.debug "-> event ID: #{evt[:event_id]}"
         else
-          puts "-> event ID: #{evt.id}"
+          Raven.logger.debug "-> event ID: #{evt.id}"
         end
       elsif evt #async configuration
         if evt.value.is_a? Hash
-          puts "-> event ID: #{evt.value[:event_id]}"
+          Raven.logger.debug "-> event ID: #{evt.value[:event_id]}"
         else
-          puts "-> event ID: #{evt.value.id}"
+          Raven.logger.debug "-> event ID: #{evt.value.id}"
         end
       else
-        puts ""
-        puts "An error occurred while attempting to send the event."
+        Raven.logger.debug ""
+        Raven.logger.debug "An error occurred while attempting to send the event."
         exit 1
       end
 
-      puts ""
-      puts "Done!"
+      Raven.logger.debug ""
+      Raven.logger.debug "Done!"
     end
   end
 end

spec/raven/cli_spec.rb

@@ -8,13 +8,14 @@
     end
 
     Raven.configure do |config|
-      config.server = 'http://12345:67890@sentry.localdomain/sentry/42'
       config.environments = ["test"]
       config.current_environment = "test"
       config.http_adapter = [:test, stubs]
+      config.silence_ready = true
     end
 
-    Raven::CLI.test
+    dsn = 'http://12345:67890@sentry.localdomain/sentry/42'
+    Raven::CLI.test(dsn, true)
 
     stubs.verify_stubbed_calls
   end
@@ -28,9 +29,11 @@
       config.environments = ["test"]
       config.current_environment = "test"
       config.http_adapter = [:test, stubs]
+      config.silence_ready = true
     end
 
-    Raven::CLI.test 'http://12345:67890@sentry.localdomain/prefix/sentry/42'
+    dsn = 'http://12345:67890@sentry.localdomain/prefix/sentry/42'
+    Raven::CLI.test(dsn, true)
 
     stubs.verify_stubbed_calls
   end

spec/raven/integrations/rails_spec.rb

@@ -7,8 +7,9 @@
     Raven.configure do |config|
       config.dsn = 'dummy://notaserver'
       config.encoding = 'json'
-      config.logger = nil
+      config.logger = false
     end
+    Rails.logger = Logger.new(nil)
     Rails.env = "production"
     TestApp.initialize!
   end

spec/raven/logger_spec.rb

@@ -6,12 +6,8 @@
       allow(Raven.configuration).to receive(:logger) { nil }
     end
 
-    it 'should not error' do
-      subject.fatal 'fatalmsg'
-      subject.error 'errormsg'
-      subject.warn 'warnmsg'
-      subject.info 'infomsg'
-      subject.debug 'debugmsg'
+    it 'logs to stdout' do
+      expect { subject.fatal 'fatalmsg' }.to output.to_stdout_from_any_process
     end
   end
 

spec/support/test_rails_app/app.rb

@@ -10,6 +10,8 @@
 # require "rails/test_unit/railtie"
 require 'raven/integrations/rails'
 
+ActiveSupport::Deprecation.silenced = true
+
 class TestApp < Rails::Application
   config.secret_key_base = "test"
 
@@ -18,9 +20,6 @@ class TestApp < Rails::Application
   config.cache_classes = true
   config.serve_static_files = false
 
-  config.log_level = :error
-  config.logger = Logger.new(STDOUT)
-
   routes.append do
     get "/exception", :to => "hello#exception"
     root :to => "hello#world"