Merge pull request #236 from getsentry/opt-out-integrations

Fix integrations depending on gem load order

Close #235

Author: nateberkopec

gemfiles/rails32.gemfile

@@ -1,7 +1,6 @@
 source "http://rubygems.org"
 
 gem "rails", "~> 3.2.6"
-gem "rake"
 gem "rspec"
 gem "simplecov"
 

gemfiles/rails40.gemfile

@@ -1,9 +1,7 @@
 source "http://rubygems.org"
 
 gem "rails", "~> 4.0.0"
-gem "rake"
 gem "rspec"
 gem "simplecov"
-gem "sentry-raven", :path => "../"
 
 gemspec :path => "../"

gemfiles/rails41.gemfile

@@ -1,9 +1,7 @@
 source "http://rubygems.org"
 
 gem "rails", "~> 4.1.0"
-gem "rake"
 gem "rspec"
 gem "simplecov"
-gem "sentry-raven", :path => "../"
 
 gemspec :path => "../"

lib/raven/base.rb

@@ -5,7 +5,6 @@
 require 'raven/client'
 require 'raven/event'
 require 'raven/logger'
-require 'raven/rack'
 require 'raven/interfaces/message'
 require 'raven/interfaces/exception'
 require 'raven/interfaces/stack_trace'
@@ -207,13 +206,9 @@ def rack_context(env)
 
     # Injects various integrations
     def inject
-      require 'raven/integrations/delayed_job' if defined?(::Delayed::Plugin)
-      require 'raven/railtie' if defined?(::Rails::Railtie)
-      require 'raven/sidekiq' if defined?(Sidekiq)
-      if defined?(Rake)
-        require 'raven/rake'
-        require 'raven/tasks'
-      end
+      available_integrations = %w[delayed_job rails sidekiq rack rake]
+      integrations_to_load = available_integrations & Gem.loaded_specs.keys
+      integrations_to_load.each { |integration| require "raven/integrations/#{integration}" }
     end
 
     # For cross-language compat

lib/raven/rack.rb renamed to lib/raven/integrations/rack.rb

@@ -1,4 +1,5 @@
 require 'time'
+require 'rack'
 
 module Raven
   # Middleware for Rack applications. Any errors raised by the upstream
@@ -20,6 +21,7 @@ module Raven
   #
   # Use a standard Raven.configure call to configure your server credentials.
   class Rack
+
     def self.capture_exception(exception, env, options = {})
       if env['requested_at']
         options[:time_spent] = Time.now - env['requested_at']

lib/raven/railtie.rb renamed to lib/raven/integrations/rails.rb

@@ -2,14 +2,14 @@
 require 'rails'
 
 module Raven
-  class Railtie < ::Rails::Railtie
+  class Rails < ::Rails::Railtie
     initializer "raven.use_rack_middleware" do |app|
       app.config.middleware.insert 0, "Raven::Rack"
     end
 
     initializer 'raven.action_controller' do
       ActiveSupport.on_load :action_controller do
-        require 'raven/rails/controller_methods'
+        require 'raven/integrations/rails/controller_methods'
         include Raven::Rails::ControllerMethods
       end
     end
@@ -22,17 +22,17 @@ class Railtie < ::Rails::Railtie
 
       if Raven.configuration.catch_debugged_exceptions
         if defined?(::ActionDispatch::DebugExceptions)
-          require 'raven/rails/middleware/debug_exceptions_catcher'
+          require 'raven/integrations/rails/middleware/debug_exceptions_catcher'
           ::ActionDispatch::DebugExceptions.send(:include, Raven::Rails::Middleware::DebugExceptionsCatcher)
         elsif defined?(::ActionDispatch::ShowExceptions)
-          require 'raven/rails/middleware/debug_exceptions_catcher'
+          require 'raven/integrations/rails/middleware/debug_exceptions_catcher'
           ::ActionDispatch::ShowExceptions.send(:include, Raven::Rails::Middleware::DebugExceptionsCatcher)
         end
       end
     end
 
     rake_tasks do
-      require 'raven/tasks'
+      require 'raven/integrations/tasks'
     end
   end
 end

lib/raven/rails/controller_methods.rb renamed to lib/raven/integrations/rails/controller_methods.rb

@@ -1,5 +1,5 @@
 module Raven
-  module Rails
+  class Rails
     module ControllerMethods
       def capture_message(message, options = {})
         Raven::Rack.capture_message(message, request.env, options)

lib/raven/rails/middleware/debug_exceptions_catcher.rb renamed to lib/raven/integrations/rails/middleware/debug_exceptions_catcher.rb

@@ -1,5 +1,5 @@
 module Raven
-  module Rails
+  class Rails
     module Middleware
       module DebugExceptionsCatcher
         def self.included(base)

lib/raven/rake.rb renamed to lib/raven/integrations/rake.rb

@@ -1,5 +1,6 @@
-require 'raven'
+require 'rake'
 require 'rake/task'
+require 'raven/integrations/tasks'
 
 module Rake
   class Application
@@ -9,5 +10,4 @@ def display_error_message(ex)
       orig_display_error_messsage(ex)
     end
   end
-end
-
+end

lib/raven/sidekiq.rb renamed to lib/raven/integrations/sidekiq.rb

@@ -1,4 +1,5 @@
 require 'time'
+require 'sidekiq'
 
 module Raven
   class Sidekiq

lib/raven/tasks.rb renamed to lib/raven/integrations/tasks.rb

@@ -19,12 +19,12 @@ def initialize(*arguments)
     end
 
     def from_rack(env)
-      require 'rack'
       req = ::Rack::Request.new(env)
-      self.url = req.url.split('?').first
+      self.url = req.scheme && req.url.split('?').first
       self.method = req.request_method
       self.query_string = req.query_string
       env.each_pair do |key, value|
+        key = key.to_s #rack env can contain symbols
         next unless key.upcase == key # Non-upper case stuff isn't either
         if key.start_with?('HTTP_')
           # Header

lib/raven/interfaces/http.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'raven/integrations/rack'
 
 describe Raven::Rack do
   it 'should capture exceptions' do

spec/raven/rack_spec.rb renamed to spec/raven/integrations/rack_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 require 'raven'
-require 'raven/rails/controller_methods'
+require 'raven/integrations/rails/controller_methods'
 
 describe Raven::Rails::ControllerMethods do
   include described_class