Correctly pass arguments to a rake task (#1514)

Author: y-yagi

sentry-ruby/lib/sentry/rake.rb

@@ -20,10 +20,10 @@ class Task
     alias orig_execute execute
 
     def execute(args=nil)
-      return orig_execute unless Sentry.initialized? && Sentry.get_current_hub
+      return orig_execute(args) unless Sentry.initialized? && Sentry.get_current_hub
 
       Sentry.get_current_hub.with_background_worker_disabled do
-        orig_execute
+        orig_execute(args)
       end
     end
   end

sentry-ruby/spec/sentry/rake_spec.rb

@@ -24,4 +24,16 @@
 
     expect(message).not_to match(/Sentry/)
   end
+
+  it "run rake task with original arguments" do
+    message = ""
+
+    # if we change the directory in the current process, it'll affect other tests that relies on system call too
+    # e.g. release detection tests
+    Thread.new do
+      message = `cd spec/support && bundle exec rake pass_arguments[arguments]`
+    end.join
+
+    expect(message).to match("arguments")
+  end
 end

sentry-ruby/spec/support/Rakefile.rb

@@ -14,3 +14,7 @@
   Sentry.configuration.skip_rake_integration = true
   1/0
 end
+
+task :pass_arguments, ['name']  do |_task, args|
+  puts args[:name]
+end