[sentry-ruby] fix and improve spec suite setup

Author: solnic

sentry-ruby/.rspec

@@ -1,2 +1,4 @@
---format documentation
+--require spec_helper
+--format progress
 --color
+--order rand

sentry-ruby/Rakefile

@@ -8,15 +8,14 @@ Bundler::GemHelper.install_tasks(name: "sentry-ruby")
 
 require "rspec/core/rake_task"
 
+ISOLATED_SPECS = "spec/isolated/**/*_spec.rb"
+
 RSpec::Core::RakeTask.new(:spec).tap do |task|
-  task.rspec_opts = "--order rand"
-  task.exclude_pattern = "spec/isolated/**/*_spec.rb"
+  task.exclude_pattern = ISOLATED_SPECS
 end
 
-task :isolated_specs do
-  Dir["spec/isolated/**/*_spec.rb"].each do |file|
-    sh "bundle exec rspec #{file}"
-  end
+RSpec::Core::RakeTask.new(:isolated_specs).tap do |task|
+  task.pattern = ISOLATED_SPECS
 end
 
 task default: [:spec, :isolated_specs]

sentry-ruby/spec/initialization_check_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "spec_helper"
-
 RSpec.describe "with uninitialized SDK" do
   before do
     # completely nuke any initialized hubs

sentry-ruby/spec/isolated/init_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../spec_helper"
-
 # isolated tests need a SimpleCov name otherwise they will overwrite coverage
 SimpleCov.command_name "RSpecIsolatedInit"
 

sentry-ruby/spec/isolated/puma_spec.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 require "puma"
-require_relative "../spec_helper"
+
+# Force-load the patches so that we don't depend on require order
+load Pathname(__FILE__).join("../../../lib/sentry/puma.rb").realpath
 
 # Because puma doesn't have any dependency, if Rack is not installed the entire test won't work
 return if ENV["RACK_VERSION"] == "0"

sentry-ruby/spec/sentry/background_worker_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "spec_helper"
-
 RSpec.describe Sentry::BackgroundWorker do
   let(:string_io) { StringIO.new }
 

sentry-ruby/spec/sentry/backpressure_monitor_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe Sentry::BackpressureMonitor do
   let(:string_io) { StringIO.new }
 

sentry-ruby/spec/sentry/backtrace/lines_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "spec_helper"
-
 RSpec.describe Sentry::Backtrace::Line do
   before do
     perform_basic_setup

sentry-ruby/spec/sentry/backtrace_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe Sentry::Backtrace do
   let(:fixture_root) { File.join(Dir.pwd, "spec", "support") }
   let(:fixture_file) { File.join(fixture_root, "stacktrace_test_fixture.rb") }

sentry-ruby/spec/sentry/baggage_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "spec_helper"
-
 RSpec.describe Sentry::Baggage do
   let(:malformed_baggage) { "," }
   let(:third_party_baggage) { "other-vendor-value-1=foo;bar;baz, other-vendor-value-2=foo;bar;" }