Ignore redis key if not UTF8 (#1997)

Author: sl0thentr0py

CHANGELOG.md

@@ -52,6 +52,8 @@
 - Fix sentry-rails' controller span nesting [#1973](https://github.com/getsentry/sentry-ruby/pull/1973)
   - Fixes [#1899](https://github.com/getsentry/sentry-ruby/issues/1899)
 - Do not report exceptions when a Rails runner exits with `exit 0` [#1988](https://github.com/getsentry/sentry-ruby/pull/1988)
+- Ignore redis key if not UTF8 [#1997](https://github.com/getsentry/sentry-ruby/pull/1997)
+  - Fixes [#1992](https://github.com/getsentry/sentry-ruby/issues/1992)
 
 ### Miscellaneous
 [

sentry-ruby/lib/sentry/redis.rb

@@ -54,7 +54,8 @@ def commands_description
     def parsed_commands
       commands.map do |statement|
         command, key, *arguments = statement
-        command_set = { command: command.to_s.upcase, key: key }
+        command_set = { command: command.to_s.upcase }
+        command_set[:key] = key if Utils::EncodingHelper.valid_utf_8?(key)
 
         if Sentry.configuration.send_default_pii
           command_set[:arguments] = arguments

sentry-ruby/spec/sentry/redis_spec.rb

@@ -30,17 +30,17 @@
           expect(request_span.data).to eq({ server: "127.0.0.1:6379/0" })
         end
 
-        it "removes bad encoding commands gracefully" do
+        it "removes bad encoding keys and arguments gracefully" do
           transaction = Sentry.start_transaction
           Sentry.get_current_scope.set_span(transaction)
 
           # random bytes
-          redis.set("key", "foo \x1F\xE6")
+          redis.set("key \x1F\xE6", "val \x1F\xE6")
 
           request_span = transaction.span_recorder.spans.last
           description = request_span.description
 
-          expect(description).to eq("SET key")
+          expect(description).to eq("SET")
 
           expect do
             JSON.generate(description)