You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CHANGELOG.md
+9-8Lines changed: 9 additions & 8 deletions
Original file line number
Diff line number
Diff line change
@@ -2,23 +2,24 @@
2
2
3
3
### Breaking Change - Goodbye `faraday` 👋
4
4
5
+
**TL;DR: If you are already on version `4.9` and do not use `config.transport.http_adapter` and `config.transport.faraday_builder`, you don't need to change anything.**
6
+
5
7
This version removes the dependency of [faraday](https://github.com/lostisland/faraday) and replaces related implementation with the `Net::HTTP` standard library.
6
8
7
-
(If you didn't notice it, the SDK previously used `faraday` as the HTTP client to send events to Sentry. You can find the implementation in [HTTPTransport](https://github.com/getsentry/sentry-ruby/blob/v4-9/sentry-ruby/lib/sentry/transport/http_transport.rb).)
8
9
9
-
#### Why
10
+
#### Why?
10
11
11
-
Since the old `sentry-raven` SDK, we've been using `faraday` as the SDKs' HTTP client for years. It's an amazing tool and saved us many work, allowing us to focus on SDK features.
12
+
Since the old `sentry-raven` SDK, we've been using `faraday` as the HTTP client for years (see [HTTPTransport](https://github.com/getsentry/sentry-ruby/blob/4-9/sentry-ruby/lib/sentry/transport/http_transport.rb)). It's an amazing tool that saved us many work and allowed us to focus on SDK features.
12
13
13
-
But because many users also use `faraday`in their own apps and have their own version requirements, managing this dependency has become harder and harder over the past few years. Just to list a few related issues:
14
+
But because many users also use `faraday`themselves and have their own version requirements, managing this dependency has become harder over the past few years. Just to list a few related issues:
And with the release of [faraday 2.0](https://github.com/lostisland/faraday/releases/tag/v2.0.0), we could only imagine it gets even more difficult (which it kinda did, see [#1663](https://github.com/getsentry/sentry-ruby/issues/1663)).
20
+
And with the release of [faraday 2.0](https://github.com/lostisland/faraday/releases/tag/v2.0.0), we could only imagine it getting even more difficult (which it kind of did, see [#1663](https://github.com/getsentry/sentry-ruby/issues/1663)).
20
21
21
-
So we decided to officially say goodbye to it with this release.
22
+
So we think it's time to say goodbye to it with this release.
22
23
23
24
24
25
#### What's changed?
@@ -31,7 +32,7 @@ The only noticeable changes are the removal of 2 faraday-specific transport conf
31
32
-`config.transport.http_adapter`
32
33
-`config.transport.faraday_builder`
33
34
34
-
**If you are already on version `4.9.x` and do not use those configuration options, it'll be as simple as `bundle update`.**
35
+
**If you are already on version `4.9` and do not use those configuration options, it'll be as simple as `bundle update`.**
35
36
36
37
#### What if I still want to use `faraday` to send my events?
37
38
@@ -125,7 +126,7 @@ end
125
126
2. Set `config.transport.transport = FaradayTransport`
126
127
127
128
128
-
**Please keep in mind that this may not work in the future when the SDK changes its transport implementation.**
129
+
**Please keep in mind that this may not work in the future when the SDK changes its `HTTPTransport` implementation.**
0 commit comments