Skip to content

[active_job] report on each retry failure #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Apr 14, 2025

⚠️ this will increase error reporting rates - we may consider setting active_job_report_after_job_retries to true by default

Closes #2597

#skip-changelog

@solnic solnic marked this pull request as ready for review April 14, 2025 13:01
@solnic solnic requested review from st0012 and sl0thentr0py April 14, 2025 13:02
@getsentry getsentry deleted a comment from github-actions bot Apr 14, 2025
@solnic
Copy link
Collaborator Author

solnic commented Apr 14, 2025

Danger is still not seeing my changelog entry :(

@getsentry getsentry deleted a comment from github-actions bot Apr 15, 2025
@solnic solnic force-pushed the 2597-activejob-missing-error-reporting-on-retries branch from dff567f to 5d1cb20 Compare April 29, 2025 14:08
@solnic solnic marked this pull request as draft April 30, 2025 11:30
@solnic solnic self-assigned this Apr 30, 2025
@solnic solnic marked this pull request as ready for review April 30, 2025 11:43
@solnic solnic changed the title [active_job] patch retry_job to report all errors during retries [active_job] report on each retry failure May 2, 2025
@solnic solnic merged commit 8c699de into master May 2, 2025
139 of 141 checks passed
@solnic solnic deleted the 2597-activejob-missing-error-reporting-on-retries branch May 2, 2025 19:18
solnic added a commit that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveJob missing error reporting on retries
2 participants