-
-
Notifications
You must be signed in to change notification settings - Fork 516
Introduce Sentry.capture_log #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
43abb90
to
6ae5bef
Compare
ca4d04c
to
be910c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! Just one comment about the client method, and then we are good to ✅
Before we move on to the logger interface though (#2604), can we spec out a buffering implementation for logs? We can do it after this PR and create another issue to track it so that we contain the scope of this particular set of changes.
https://develop.sentry.dev/sdk/telemetry/logs/#implementation
It would be nice to get a lightweight logs buffer so that we don't overwhelm sentry with requests, logs were designed so you can send multiple log payloads in a single log envelope.
@AbhiPrasad yes this makes sense, I reported #2613 :) |
@AbhiPrasad I added remaining pieces of info to the attributes, please take another look 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change with server_name
, but approving to unblock! Thanks for the quick pace on this.
First step towards Structured Logging #2600
This adds
Sentry.capture_log
interface with a new underlyingLogEvent
event type.Closes #2603