Skip to content

Fix coverage by making sure isolated specs have SimpleCov.command_name #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented May 15, 2025

also

  • make sure only spec files are run by the :isolated_specs task (and not the helper ruby init file)
  • upload coverage for all delayed_job runs

see https://github.com/simplecov-ruby/simplecov?tab=readme-ov-file#merging-results

#skip-changelog

@sl0thentr0py sl0thentr0py requested a review from solnic May 15, 2025 12:11
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (c509ce1) to head (13b6a3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2629       +/-   ##
===========================================
+ Coverage   64.15%   97.43%   +33.28%     
===========================================
  Files         127      133        +6     
  Lines        4918     5114      +196     
===========================================
+ Hits         3155     4983     +1828     
+ Misses       1763      131     -1632     
Components Coverage Δ
sentry-ruby 97.70% <ø> (+37.92%) ⬆️
sentry-rails 96.55% <ø> (+36.29%) ⬆️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (-0.98%) ⬇️
sentry-opentelemetry 99.31% <ø> (ø)

see 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-isolated-spec-coverage branch 2 times, most recently from e9b0899 to 96f9f62 Compare May 15, 2025 12:55
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-isolated-spec-coverage branch from 96f9f62 to 13b6a3a Compare May 15, 2025 13:00
@sl0thentr0py sl0thentr0py merged commit de9f210 into master May 15, 2025
138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-isolated-spec-coverage branch May 15, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants