feat(sentry-rails): Allow severity to pass what is available at level when using ActiveSupport::ErrorReporter
#2637
+103
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vel` when using ActiveSupport::ErrorReporter The following are available for `level` in `sentry-rails`. - :fatal - :error - :warning - :log - :info - :debug cf. https://docs.sentry.io/platforms/ruby/guides/rails/usage/set-level/ But in the case of `severity` in ActiveSupport::ErrorReporter#report, ArgumentError is raised if anything other than the following is passed. - :error - :warning - :info cf. https://github.com/rails/rails/blob/v8.0.2/activesupport/lib/active_support/error_reporter.rb#L220-L222 cf. https://github.com/rails/rails/blob/v8.0.2/activesupport/lib/active_support/error_reporter.rb#L27 So I added symbols to ActiveSupport::ErrorReporter::SEVERITIES that is allowed as `level` when registering Sentry::Rails::ErrorSubscriber. It also supports the behavior that `warn` is considered as `warning`. cf. https://github.com/getsentry/sentry-ruby/blame/5.24.0/sentry-ruby/lib/sentry/event.rb#L100-L102
|
Thank you for the PR - one question though: how does it happen that you end up with the I need to understand better what the actual problem is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following are available for
levelinsentry-rails.cf. https://docs.sentry.io/platforms/ruby/guides/rails/usage/set-level/
But in the case of
severityin ActiveSupport::ErrorReporter#report, ArgumentError is raised if anything other than the following is passed.cf. https://github.com/rails/rails/blob/v8.0.2/activesupport/lib/active_support/error_reporter.rb#L220-L222
cf. https://github.com/rails/rails/blob/v8.0.2/activesupport/lib/active_support/error_reporter.rb#L27
So I added symbols to ActiveSupport::ErrorReporter::SEVERITIES that is allowed as
levelwhen registering Sentry::Rails::ErrorSubscriber.It also supports the behavior that
warnis considered aswarning.cf. https://github.com/getsentry/sentry-ruby/blob/5.24.0/sentry-ruby/lib/sentry/event.rb#L100-L102