Skip to content

feat(sentry-rails): Allow severity to pass what is available at level when using ActiveSupport::ErrorReporter #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sentry-rails/lib/sentry/rails/railtie.rb
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ def activate_tracing

def register_error_subscriber(app)
require "sentry/rails/error_subscriber"
ActiveSupport::ErrorReporter::SEVERITIES.push(
*%i[fatal log debug warn].reject { |severity| ActiveSupport::ErrorReporter::SEVERITIES.include?(severity) }
)
app.executor.error_reporter.subscribe(Sentry::Rails::ErrorSubscriber.new)
end
end
Expand Down
100 changes: 100 additions & 0 deletions sentry-rails/spec/sentry/rails_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,106 @@ def capture_in_separate_process(exit_code:)

expect(transport.events.count).to eq(0)
end

context "when passed a severity" do
context "when severity is fatal" do
it "sets fatal level to the reported event" do
Rails.error.handle(severity: :fatal) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:fatal)
end
end

context "when severity is error" do
it "sets error level to the reported event" do
Rails.error.handle(severity: :error) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:error)
end
end

context "when severity is warning" do
it "sets warning level to the reported event" do
Rails.error.handle(severity: :warning) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:warning)
end
end

context "when severity is warn" do
it "sets warning level to the reported event" do
Rails.error.handle(severity: :warn) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:warning)
end
end

context "when severity is log" do
it "sets log level to the reported event" do
Rails.error.handle(severity: :log) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:log)
end
end

context "when severity is info" do
it "sets info level to the reported event" do
Rails.error.handle(severity: :info) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:info)
end
end

context "when severity is debug" do
it "sets debug level to the reported event" do
Rails.error.handle(severity: :debug) do
1/0
end

expect(transport.events.count).to eq(1)

event = transport.events.first

expect(event.level).to eq(:debug)
end
end
end
end
end
end