feat(tracing): send both breadcrumbs and logs by default #878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new function
default_event_filter_with_logs
which is the same as the default one but also sends logs for anything above INFO.If the
sentry
crate is used with thelogs
feature and there's already a Hub active, grabenable_logs
from the associated client and use the new default filter with logs if possible.Users still need to opt into sending logs by enabling the feature flag and setting
enable_logs: true
, but this makes it easier if you don't want to set up a custom event filter, and it also makes the onboarding docs simpler.An alternative to implement this would be to map tracing events to logs just by looking at the
logs
feature flag being enabled, but that way the user would still incur a performance penalty in the case they haveenable_logs: false
in their options, as we would anyways convert eachtracing
event to a Sentry log unnecessarily.Close #871