feat(on-demand): Add feature flag check before cardinality check #98726
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
narsaynorath
commented
Sep 3, 2025
| @@ -423,6 +423,9 @@ def check_field_cardinality( | |||
| is_task: bool = False, | |||
| widget_query: DashboardWidgetQuery | None = None, | |||
| ) -> dict[str, str]: | |||
| if not features.has("organizations:on-demand-metrics-extraction-widgets", organization): | |||
There was a problem hiding this comment.
@k-fish would you be able to advise if this is okay for us to do? I suppose when we migrate fully to EAP then we can get rid of this, but in an effort to make some easy progress for other users, I figured we could just feature flag this check
It seems like we wanted to evaluate it even without the feature flag so when we rolled out, people's queries were good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are experiencing high latency due to this cardinality check. Since metrics extraction for widgets has paused and we're in the process of migrating users to spans/EAP, I figured we could avoid running this check for users that do not have the feature flag if we're not planning to continue rolling it out.
e.g. this trace shows 15s waiting for the cardinality check for an org that doesn't have access