fix(typing): Remove sentry_plugins.jira.plugin from problem list #98730
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made minimal changes to allow mypy to pass with the file removed from the problem list. Notably, the base class method doesn't actually require the `Request`, so I split it out into an `_impl` method so that the child class could call in without one (while maintaining the existing function type signature through the hierarchy). Test plan: `mypy` no errors
github-actions
bot
added
the
Scope: Backend
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
) Made minimal changes to allow mypy to pass with the file removed from the problem list. Notably, the base class method doesn't actually require the `Request`, so I split it out into an `_impl` method so that the child class could call in without one (while maintaining the existing function type signature through the hierarchy). Test plan: `mypy` no errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made minimal changes to allow mypy to pass with the file removed from the problem list.
Notably, the base class method doesn't actually require the
Request, so I split it out into an_implmethod so that the child class could call in without one (while maintaining the existing function type signature through the hierarchy).Test plan:
mypyno errors