Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ module = [
"sentry.services.eventstore.models",
"sentry.snuba.metrics.query_builder",
"sentry.testutils.cases",
"sentry_plugins.jira.plugin",
"tests.sentry.api.helpers.test_group_index",
"tests.sentry.issues.test_utils",
]
Expand Down
3 changes: 3 additions & 0 deletions src/sentry/plugins/bases/issue2.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ def get_new_issue_fields(self, request: Request, group, event, **kwargs):
"""
If overriding, supported properties include 'readonly': true
"""
return self._get_new_issue_fields_impl(group, event)

def _get_new_issue_fields_impl(self, group, event):
return [
{
"name": "title",
Expand Down
8 changes: 4 additions & 4 deletions src/sentry_plugins/jira/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ def get_issue_type_meta(self, issue_type, meta):

return issue_type_meta

def get_new_issue_fields(self, request: Request, group, event, **kwargs):
fields = super().get_new_issue_fields(request, group, event, **kwargs)
def get_new_issue_fields(self, request: Request | None, group, event, **kwargs):
fields = super()._get_new_issue_fields_impl(group, event)

jira_project_key = self.get_option("default_project", group.project)

Expand Down Expand Up @@ -414,7 +414,7 @@ def error_message_from_json(self, data):
message += " ".join(f"{k}: {v}" for k, v in data.get("errors").items())
return message

def create_issue(self, request: Request, group, form_data):
def create_issue(self, request: Request | None, group, form_data):
cleaned_data = {}

# protect against mis-configured plugin submitting a form without an
Expand Down Expand Up @@ -678,7 +678,7 @@ def post_process(self, *, group, event, is_new, **kwargs):
)

try:
issue_id = self.create_issue(request={}, group=group, form_data=post_data)
issue_id = self.create_issue(request=None, group=group, form_data=post_data)
except PluginError as e:
logger.info("post_process.fail", extra={"error": str(e)})
else:
Expand Down
Loading