chore(ACI): Add logs for triggers to compare both systems #98758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98758 +/- ##
==========================================
+ Coverage 76.04% 81.20% +5.16%
==========================================
Files 8531 8531
Lines 376551 376626 +75
Branches 23870 23870
==========================================
+ Hits 286330 305845 +19515
+ Misses 89854 70414 -19440
Partials 367 367 |
kcons
approved these changes
Sep 3, 2025
| logger.info( | ||
| "subscription_processor.alert_triggered", | ||
| extra={ | ||
| "rule_id": self.alert_rule.id, |
There was a problem hiding this comment.
maybe worth including project or org id in here just because it's easy and might make subset examination a bit easier.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
Add logs on both the subscription processor when a trigger's threshold is met or resolved and in workflow engine when the workflow's trigger conditions are met so that we can compare the two systems. Both logs have the detector ID so we can match them up and are behind a flag with a small subset of organizations flagged in so it won't be too much data.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logs on both the subscription processor when a trigger's threshold is met or resolved and in workflow engine when the workflow's trigger conditions are met so that we can compare the two systems. Both logs have the detector ID so we can match them up and are behind a flag with a small subset of organizations flagged in so it won't be too much data.