feat: uv (#7368)

Author: joshuarli

.dockerignore

@@ -18,3 +18,4 @@ snuba.egg-info/
 snuba/admin/dist/bundle.js*
 */node_modules
 rust_snuba/target/
+/.devenv

.envrc

@@ -21,4 +21,6 @@ fi
 export VIRTUAL_ENV="${PWD}/.venv"
 PATH_add "${PWD}/.venv/bin"
 
+PATH_add /opt/homebrew/opt/rustup/bin
+
 . scripts/rust-envvars

.github/workflows/bump-version.yml

@@ -32,6 +32,9 @@ jobs:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
         token: ${{ secrets.GETSENTRY_BOT_REVERT_TOKEN }}
+    - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
+      with:
+        version: '0.8.2'
     - run: |
         set -euxo pipefail
 
@@ -41,8 +44,9 @@ jobs:
 
         git checkout -b "bot/bump-version/$PACKAGE/$VERSION"
 
+        python3 -S -m tools.bump_version "$PACKAGE" "$VERSION"
+
         re="$(sed 's/[_-]/[_-]/g' <<< "$PACKAGE")"
-        sed -i "s/^\($re\)==.*/\1==$VERSION/g" -- requirements*.txt
 
         # Update Cargo.toml dependencies (format: package = "version")
         sed -i "s/^\($re\) = \"[^\"]*\"/\1 = \"$VERSION\"/g" -- rust_snuba/Cargo.toml

.github/workflows/ci.yml

@@ -27,7 +27,7 @@ jobs:
   linting:
     name: "pre-commit hooks" # (includes Python formatting + linting)
     runs-on: ubuntu-latest
-    timeout-minutes: 5
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
         name: Checkout code
@@ -38,19 +38,28 @@ jobs:
         with:
           app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
           private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
-      - uses: actions/setup-python@v5
+
+      - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
         with:
-          python-version: '3.11'
-      - uses: actions/cache@v4
+          version: '0.8.2'
+          # we just cache the venv-dir directly in action-setup-venv
+          enable-cache: false
+
+      - uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
+        with:
+          python-version: 3.11.11
+          cache-dependency-path: uv.lock
+          # NOTE: can't pass --only-dev yet since we're missing some mypy stub packages
+          install-cmd: uv sync --frozen --active
+
+      - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
         with:
           path: ~/.cache/pre-commit
-          key: cache-epoch-1|${{ env.pythonLocation }}|${{ hashFiles('.pre-commit-config.yaml') }}
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install -r requirements-test.txt
+          key: cache-epoch-1|${{ env.pythonLocation }}|${{ hashFiles('.pre-commit-config.yaml', 'uv.lock') }}
+
       - name: Setup pre-commit
-        run: make setup-git
+        run: pre-commit install-hooks
+
       - uses: getsentry/paths-filter@v2
         id: files
         with:
@@ -65,6 +74,7 @@ jobs:
           filters: |
             all:
               - added|modified: '**/*'
+
       - name: Run pre-commit checks
         # Run pre-commit to lint and format check files that were changed (but not deleted) compared to master.
         # XXX: there is a very small chance that it'll expand to exceed Linux's limits
@@ -96,38 +106,26 @@ jobs:
         run: |
           make lint-rust format-rust-ci
 
-  typing:
-    name: "mypy typing"
-    runs-on: ubuntu-latest
-    timeout-minutes: 5
-    steps:
-      - uses: actions/checkout@v4
-        name: Checkout code
-      - uses: actions/setup-python@v5
-        with:
-          python-version: '3.11'
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          make install-python-dependencies
-      - name: Run mypy
-        run: |
-          make backend-typing
-
   config-validation:
     name: "Dataset Config Validation"
     runs-on: ubuntu-latest
     timeout-minutes: 2
     steps:
       - uses: actions/checkout@v4
         name: Checkout code
-      - uses: actions/setup-python@v5
+
+      - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
         with:
-          python-version: '3.11'
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          make install-python-dependencies
+          version: '0.8.2'
+          # we just cache the venv-dir directly in action-setup-venv
+          enable-cache: false
+
+      - uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
+        with:
+          python-version: 3.11.11
+          cache-dependency-path: uv.lock
+          install-cmd: uv sync --frozen --active
+
       - name: Validate configs
         run: |
           make validate-configs
@@ -293,7 +291,6 @@ jobs:
       - name: Setup steps
         id: setup
         run: |
-          pip install --upgrade pip wheel
           # We cannot execute actions that are not placed under .github of the main repo
           mkdir -p .github/actions
           cp -r sentry/.github/actions/* .github/actions
@@ -404,15 +401,23 @@ jobs:
         run: |
           curl -Os https://uploader.codecov.io/latest/linux/codecov && chmod +x codecov && ./codecov -t ${CODECOV_TOKEN}
 
-
   validate-devservices-config:
     runs-on: ubuntu-24.04
     needs: files-changed
     if: ${{ needs.files-changed.outputs.devservices_changes == 'true' }}
     steps:
     - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       name: Checkout repository
-    - uses: getsentry/action-validate-devservices-config@02a078d1280293e6598cabfbd318a01609c12c83
+
+    - name: Get devservices version
+      id: get-devservices-version
+      run: |
+        awk -F'"' '
+          /name/ { pkg = $2 }
+          /version/ { if (pkg == "devservices") print "version="$2 }
+        ' uv.lock >> $GITHUB_OUTPUT
+
+    - uses: getsentry/action-validate-devservices-config@711ae7221998ddf81211f25f5e3873ecffd22387
       name: Validate devservices config
       with:
-        requirements-file-path: requirements-test.txt
+        devservices-version: ${{ steps.get-devservices-version.outputs.version }}

.github/workflows/ddl-changes.yml

@@ -20,13 +20,19 @@ jobs:
         with:
           clean: false
           fetch-depth: 200
-      - uses: actions/setup-python@v5
+
+      - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
         with:
-          python-version: '3.11'
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          make install-python-dependencies
+          version: '0.8.2'
+          # we just cache the venv-dir directly in action-setup-venv
+          enable-cache: false
+
+      - uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
+        with:
+          python-version: 3.11.11
+          cache-dependency-path: uv.lock
+          install-cmd: uv sync --frozen --active
+
       - name: Run the migration script
         run: |
           SNUBA_SETTINGS=test_distributed python scripts/ddl-changes.py

.github/workflows/docs-pr.yml

@@ -9,14 +9,23 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Python
-        uses: actions/setup-python@v5
+
+      - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
+        with:
+          version: '0.8.2'
+          # we just cache the venv-dir directly in action-setup-venv
+          enable-cache: false
+
+      - uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
         with:
-          python-version: '3.8'
+          python-version: 3.11.11
+          cache-dependency-path: docs-requirements.txt
+          install-cmd: echo
+
       - name: Generate config schema docs
         run: |
-          pip install virtualenv
           make generate-config-docs
+
       - name: Build docs
         run: |
           make snubadocs

.github/workflows/docs.yml

@@ -11,17 +11,27 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Python
-        uses: actions/setup-python@v5
+
+      - uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
+        with:
+          version: '0.8.2'
+          # we just cache the venv-dir directly in action-setup-venv
+          enable-cache: false
+
+      - uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
         with:
-          python-version: '3.8'
+          python-version: 3.11.11
+          cache-dependency-path: docs-requirements.txt
+          install-cmd: echo
+
       - name: Generate config schema docs
         run: |
-          pip install virtualenv
           make generate-config-docs
+
       - name: Build docs
         run: |
           make snubadocs
+
       - uses: peaceiris/actions-gh-pages@v4.0.0
         name: Publish to GitHub Pages
         with:

.pre-commit-config.yaml

@@ -6,54 +6,69 @@ exclude: >
     )
 
 repos:
-  - repo: https://github.com/psf/black
-    rev: 22.3.0
+  - repo: local
     hooks:
+      # Configuration for black exists in pyproject.toml,
+      # but we let pre-commit take care of the file filtering.
       - id: black
-  - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.2.0
-    hooks:
-      - id: check-case-conflict
-      - id: check-merge-conflict
-      - id: check-symlinks
-      - id: check-xml
-      - id: check-yaml
-      - id: detect-private-key
-      - id: end-of-file-fixer
-      - id: trailing-whitespace
-      - id: fix-encoding-pragma
-        args: ["--remove"]
-  - repo: https://github.com/pycqa/flake8
-    rev: 4.0.1
-    hooks:
-      - id: flake8
-  - repo: https://github.com/pycqa/isort
-    rev: 5.12.0
-    hooks:
+        name: black
+        entry: black
+        language: system
+        types_or: [python, pyi]
+        require_serial: true
+      # Configuration for isort exists in pyproject.toml,
+      # but we let pre-commit take care of the file filtering.
       - id: isort
-        name: isort (python)
-  - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.2.0
-    hooks:
-      - id: no-commit-to-branch
-        args: ['--branch', 'master']
-  - repo: local
-    hooks:
+        name: isort
+        entry: isort
+        language: system
+        types: [python]
+      # Configuration for flake8 exists in setup.cfg,
+      # but we let pre-commit take care of the file filtering.
+      - id: flake8
+        name: flake8
+        entry: flake8
+        language: system
+        types: [python]
+        require_serial: true
+
+      - id: mypy
+        name: mypy
+        entry: mypy
+        language: system
+        types: [python]
+        require_serial: true
+
       - id: validate-configs-syntax
         name: validate-configs-syntax
         entry: env SNUBA_SETTINGS=test python3 -m snuba.validate_configs
         language: python
         additional_dependencies: [ 'fastjsonschema', 'pyyaml', 'sentry_sdk' ]
         pass_filenames: false
         files: 'snuba/datasets/configuration/.*'
-  - repo: local
-    hooks:
       - id: cargo-fmt
         name: format rust code
         language: system
         # keep in sync with Cargo.toml. There is no way to run cargo fmt for specific files
         # https://github.com/rust-lang/rustfmt/issues/4485
         entry: rustfmt --edition 2021
         files: ^rust_snuba/.*\.rs$
-default_language_version:
-  python: python3.11
+
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: check-case-conflict
+      - id: check-executables-have-shebangs
+      - id: check-merge-conflict
+      - id: check-symlinks
+      - id: check-xml
+      - id: check-yaml
+      - id: detect-private-key
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+      - id: fix-encoding-pragma
+        args: ["--remove"]
+      - id: no-commit-to-branch
+        args: ['--branch', 'master']
+      - id: check-added-large-files
+        args: ['--maxkb=1024']