Skip to content

fix(oncall): Stop emitting useless warning #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(oncall): Stop emitting useless warning #7242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42d0b2f
Stop emitting useless warning
volokluev Jun 17, 2025
0002d8c
Merge branch 'master' into volo/no_warning
volokluev Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions snuba/pipeline/stages/query_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,7 @@ def _run_and_apply_column_names(
for select_col in clickhouse_query.get_selected_columns():
alias = select_col.expression.alias
name = select_col.name
if alias is None or name is None:
logger.warning(
"Missing alias or name for selected expression",
extra={
"selected_expression_name": name,
"selected_expression_alias": alias,
},
exc_info=True,
)
elif alias in alias_name_mapping and name not in alias_name_mapping[alias]:
if alias in alias_name_mapping and name not in alias_name_mapping[alias]:
alias_name_mapping[alias].append(name)
else:
alias_name_mapping[alias] = [name]
Expand Down
Loading