[wgpu-hal]: MVP no_std support#7599
Merged
cwfitzgerald merged 7 commits intogfx-rs:trunkfrom May 30, 2025
Merged
Conversation
Contributor
Author
|
CI / Clippy WASM Core 1.0 is an expected failure while #7585 is not merged. |
cwfitzgerald
requested changes
May 29, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Some very minor things, but g2g after those :)
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Contributor
Author
|
Should be good to go now! |
Member
|
Could you do that transform on the other backends which have a validation canary, as well - forgot to note them. |
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
6 tasks
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* MVP `no_std` support in `wgpu-hal` * Update CHANGELOG.md * Fix visibility * Fix unused imports * Response to feedback Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com> * Update other `validation_canary` usages Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com> --------- Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
no_stdpolyfill forround_ties_evenforf32andf64#7585Description
wgpu-typeswhen used as a workspace dependency, and then re-enable in affected crates.wgpu-halto theno_stdCI task.parking_lotinwgpu-halto only the features that actually use it.wgpu-hal,validation_canary, which controls the compilation of theVALIDATION_CANARYstatic, and only enable it inwgpu-tests. This was the only unconditional use ofparking_lotinwgpu-hal, and since it's an internal debugging feature, I believe it makes sense to feature-gate it as such.Testing
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.