[naga] Write only the current entrypoint #7626
Open
+129
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the MSL and HLSL backends to support writing only a single entry point, and uses them that way in wgpu-hal. (The GLSL and SPIR-V backends already provide an entry point selector.)
This is working towards a fix for #5885, but this change doesn't alter override processing or validation, so we will still reject shaders for missing overrides whether or not they are used.
Testing
Both the write-one-entrypoint and write-all-entrypoints cases are exercised either by existing or changed code. Existing tests cover the change in behavior, in that the tests still work, even when no longer writing all entrypoints to the output. Additional partial-output test cases will be added with the complete fix for #5885.
Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.