Skip to content

Add support for Debian 12 and Ubuntu 24.04 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ jobs:
- "el8"
- "el9"
- "debian-11"
- "debian-12"
- "ubuntu-2004"
- "ubuntu-2204"
- "ubuntu-2404"
puppet:
- "puppet7"
- "puppet8"
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@ known to work on many, many platforms since its creation in 2010.
* Archlinux
* Debian 10
* Debian 11
* Debian 12
* EL 7
* EL 8
* EL 9
* Ubuntu 18.04 LTS
* Ubuntu 20.04 LTS
* Ubuntu 22.04 LTS
* Ubuntu 24.04 LTS
* Solaris 10
* Solaris 11

Expand Down
24 changes: 24 additions & 0 deletions data/os/Debian/12.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
# Debian 12 defaults in alphabetical order per class
ssh::gss_api_authentication: 'yes'
ssh::hash_known_hosts: 'yes'
ssh::host: '*'
ssh::include: '/etc/ssh/ssh_config.d/*.conf'
ssh::packages:
- 'openssh-client'
ssh::send_env:
- 'LANG'
- 'LC_*'

ssh::server::accept_env:
- 'LANG'
- 'LC_*'
ssh::server::kbd_interactive_authentication: 'no'
ssh::server::include: '/etc/ssh/sshd_config.d/*.conf'
ssh::server::packages:
- 'openssh-server'
ssh::server::print_motd: 'no'
ssh::server::service_name: 'ssh'
ssh::server::subsystem: 'sftp /usr/lib/openssh/sftp-server'
ssh::server::use_pam: 'yes'
ssh::server::x11_forwarding: 'yes'
25 changes: 25 additions & 0 deletions data/os/Ubuntu/24.04.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
# Ubuntu 24.04 defaults in alphabetical order per class
ssh::gss_api_authentication: 'yes'
ssh::hash_known_hosts: 'yes'
ssh::host: '*'
ssh::include: '/etc/ssh/ssh_config.d/*.conf'
ssh::packages:
- 'openssh-client'
ssh::send_env:
- 'LANG'
- 'LC_*'

ssh::server::accept_env:
- 'LANG'
- 'LC_*'
ssh::server::kbd_interactive_authentication: 'no'
ssh::server::include: '/etc/ssh/sshd_config.d/*.conf'
ssh::server::packages:
- 'openssh-server'
ssh::server::password_authentication: 'yes'
ssh::server::print_motd: 'no'
ssh::server::service_name: 'ssh'
ssh::server::subsystem: 'sftp /usr/lib/openssh/sftp-server'
ssh::server::use_pam: 'yes'
ssh::server::x11_forwarding: 'yes'
6 changes: 4 additions & 2 deletions metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
{
"operatingsystem": "Debian",
"operatingsystemrelease": [
"11"
"11",
"12"
]
},
{
Expand Down Expand Up @@ -86,7 +87,8 @@
"operatingsystem": "Ubuntu",
"operatingsystemrelease": [
"20.04",
"22.04"
"22.04",
"24.04"
]
}
],
Expand Down
27 changes: 27 additions & 0 deletions spec/acceptance/nodesets/debian-12.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
HOSTS:
debian12:
roles:
- agent
platform: debian-12-amd64
hypervisor: docker
image: debian:12
docker_preserve_image: true
docker_cmd:
- '/sbin/init'
docker_image_commands:
- 'apt-get install -y wget net-tools systemd-sysv locales apt-transport-https ca-certificates'
- 'echo "LC_ALL=en_US.UTF-8" >> /etc/environment'
- 'echo "en_US.UTF-8 UTF-8" >> /etc/locale.gen'
- 'echo "LANG=en_US.UTF-8" > /etc/locale.conf'
- 'locale-gen en_US.UTF-8'
docker_env:
- LANG=en_US.UTF-8
- LANGUAGE=en_US.UTF-8
- LC_ALL=en_US.UTF-8
docker_container_name: 'ssh-debian12'
CONFIG:
log_level: debug
type: foss
ssh:
password: root
auth_methods: ["password"]
24 changes: 24 additions & 0 deletions spec/acceptance/nodesets/ubuntu-2404.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
HOSTS:
ubuntu2404:
roles:
- agent
platform: ubuntu-24.04-amd64
hypervisor : docker
image: ubuntu:24.04
docker_preserve_image: true
docker_cmd: '["/sbin/init"]'
docker_image_commands:
- "rm -f /etc/dpkg/dpkg.cfg.d/excludes"
- 'apt-get install -y wget net-tools iproute2 locales apt-transport-https ca-certificates'
- 'locale-gen en_US.UTF-8'
docker_env:
- LANG=en_US.UTF-8
- LANGUAGE=en_US.UTF-8
- LC_ALL=en_US.UTF-8
docker_container_name: 'ssh-ubuntu2404'
CONFIG:
log_level: debug
type: foss
ssh:
password: root
auth_methods: ["password"]
2 changes: 1 addition & 1 deletion spec/classes/init_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
when %r{Debian-10}, %r{Ubuntu-18.04}
packages_client = ['openssh-client']
packages_server = ['openssh-server']
when %r{Debian-11}, %r{Ubuntu-(20.04|22.04)}
when %r{Debian-1[12]}, %r{Ubuntu-(20.04|22.04|24.04)}
packages_client = ['openssh-client']
packages_server = ['openssh-server']
include_dir = '/etc/ssh/ssh_config.d'
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/server_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
packages = ['openssh-server']
service_hasstatus = true
service_name = 'ssh'
when %r{Debian-11}, %r{Ubuntu-(20.04|22.04)}
when %r{Debian-1[12]}, %r{Ubuntu-(20.04|22.04|24.04)}
config_mode = '0600'
packages = ['openssh-server']
service_hasstatus = true
Expand Down
11 changes: 11 additions & 0 deletions spec/fixtures/testing/Debian-12_ssh_config
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This file is being maintained by Puppet.
# DO NOT EDIT
#
# See https://man.openbsd.org/ssh_config for more info

Host *
GSSAPIAuthentication yes
HashKnownHosts yes
Include /etc/ssh/ssh_config.d/*.conf
SendEnv LANG
SendEnv LC_*
13 changes: 13 additions & 0 deletions spec/fixtures/testing/Debian-12_sshd_config
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# This file is being maintained by Puppet.
# DO NOT EDIT
#
# See https://man.openbsd.org/sshd_config for more info

Include /etc/ssh/sshd_config.d/*.conf
AcceptEnv LANG
AcceptEnv LC_*
KbdInteractiveAuthentication no
PrintMotd no
Subsystem sftp /usr/lib/openssh/sftp-server
UsePAM yes
X11Forwarding yes
11 changes: 11 additions & 0 deletions spec/fixtures/testing/Ubuntu-24.04_ssh_config
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This file is being maintained by Puppet.
# DO NOT EDIT
#
# See https://man.openbsd.org/ssh_config for more info

Host *
GSSAPIAuthentication yes
HashKnownHosts yes
Include /etc/ssh/ssh_config.d/*.conf
SendEnv LANG
SendEnv LC_*
14 changes: 14 additions & 0 deletions spec/fixtures/testing/Ubuntu-24.04_sshd_config
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# This file is being maintained by Puppet.
# DO NOT EDIT
#
# See https://man.openbsd.org/sshd_config for more info

Include /etc/ssh/sshd_config.d/*.conf
AcceptEnv LANG
AcceptEnv LC_*
KbdInteractiveAuthentication no
PasswordAuthentication yes
PrintMotd no
Subsystem sftp /usr/lib/openssh/sftp-server
UsePAM yes
X11Forwarding yes
Loading