From adf62c3fe656b094356555411c670af8ffe5fddc Mon Sep 17 00:00:00 2001
From: Samuele Martini <samuele.rw@gmail.com>
Date: Tue, 27 May 2025 13:16:16 +0200
Subject: [PATCH] Moved custom log file from concrete implementation to
 dependency injection approch to reduce overhead in the runtime phase

---
 Controller/Adminhtml/Reports/Delete.php |  2 +-
 Model/Clean.php                         |  2 +-
 Model/Log/Logger.php                    | 13 -------------
 Model/LogHandle.php                     |  2 +-
 etc/di.xml                              | 19 +++++++++++++++++--
 5 files changed, 20 insertions(+), 18 deletions(-)
 delete mode 100644 Model/Log/Logger.php

diff --git a/Controller/Adminhtml/Reports/Delete.php b/Controller/Adminhtml/Reports/Delete.php
index 936d8b4..e222b0d 100644
--- a/Controller/Adminhtml/Reports/Delete.php
+++ b/Controller/Adminhtml/Reports/Delete.php
@@ -9,7 +9,7 @@
 namespace GhostUnicorns\WebapiLogs\Controller\Adminhtml\Reports;
 
 use Exception;
-use GhostUnicorns\WebapiLogs\Model\Log\Logger;
+use Psr\Log\LoggerInterface as Logger;
 use GhostUnicorns\WebapiLogs\Model\ResourceModel\Entity\LogCollectionFactory;
 use Magento\Backend\App\Action;
 use Magento\Backend\App\Action\Context;
diff --git a/Model/Clean.php b/Model/Clean.php
index 7124e51..629c6b4 100644
--- a/Model/Clean.php
+++ b/Model/Clean.php
@@ -10,7 +10,7 @@
 
 use DateTime;
 use Exception;
-use GhostUnicorns\WebapiLogs\Model\Log\Logger;
+use Psr\Log\LoggerInterface as Logger;
 use GhostUnicorns\WebapiLogs\Model\ResourceModel\Entity\LogCollectionFactory;
 use GhostUnicorns\WebapiLogs\Model\ResourceModel\LogResourceModel;
 
diff --git a/Model/Log/Logger.php b/Model/Log/Logger.php
deleted file mode 100644
index be7b345..0000000
--- a/Model/Log/Logger.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-/*
- * Copyright © Ghost Unicorns snc. All rights reserved.
- * See LICENSE for license details.
- */
-
-declare(strict_types=1);
-
-namespace GhostUnicorns\WebapiLogs\Model\Log;
-
-class Logger extends \Monolog\Logger
-{
-}
diff --git a/Model/LogHandle.php b/Model/LogHandle.php
index 1522536..6e88f2b 100644
--- a/Model/LogHandle.php
+++ b/Model/LogHandle.php
@@ -9,7 +9,7 @@
 namespace GhostUnicorns\WebapiLogs\Model;
 
 use Exception;
-use GhostUnicorns\WebapiLogs\Model\Log\Logger;
+use Psr\Log\LoggerInterface as Logger;
 use GhostUnicorns\WebapiLogs\Model\ResourceModel\LogResourceModel;
 
 class LogHandle
diff --git a/etc/di.xml b/etc/di.xml
index d5cb5e1..eb15f6d 100644
--- a/etc/di.xml
+++ b/etc/di.xml
@@ -7,7 +7,7 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
     <!-- Log start -->
-    <type name="GhostUnicorns\WebapiLogs\Model\Log\Logger">
+    <virtualType name="GhostUnicorns\WebapiLogs\Model\Log\Logger" type="Magento\Framework\Logger\Monolog">
         <arguments>
             <argument name="name" xsi:type="string">GhostUnicorns::WebapiLogs</argument>
             <argument name="handlers" xsi:type="array">
@@ -16,12 +16,27 @@
                 </item>
             </argument>
         </arguments>
-    </type>
+    </virtualType>
     <virtualType name="GhostUnicorns\WebapiLogs\Log\Handler" type="Magento\Framework\Logger\Handler\Base">
         <arguments>
             <argument name="fileName" xsi:type="string">/var/log/webapi_logs.log</argument>
         </arguments>
     </virtualType>
+    <type name="GhostUnicorns\WebapiLogs\Model\LogHandle">
+        <arguments>
+            <argument name="logger" xsi:type="object">GhostUnicorns\WebapiLogs\Model\Log\Logger</argument>
+        </arguments>
+    </type>
+    <type name="GhostUnicorns\WebapiLogs\Model\Clean">
+        <arguments>
+            <argument name="logger" xsi:type="object">GhostUnicorns\WebapiLogs\Model\Log\Logger</argument>
+        </arguments>
+    </type>
+    <type name="GhostUnicorns\WebapiLogs\Controller\Adminhtml\Reports\Delete">
+        <arguments>
+            <argument name="logger" xsi:type="object">GhostUnicorns\WebapiLogs\Model\Log\Logger</argument>
+        </arguments>
+    </type>
     <!-- Log end -->
 
     <!-- Command start -->