Add list_shuffle and list_sample funtions to random.
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
end up picking the same element twice from a given list (follow `stdlib` fixed).
|
Could you merge or take a look at this PR pretty please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #13. The function's algorithm and doc strings (include example) were ported fatefully from the
gleam_stdlib.However, there is a need to create some internal functions
std_intandstd_floatthat act more like theirs counterpart in thegleam_stdlib, because:int.randomdoc: "The lower number is inclusive, the upper number is exclusive."float.randomdoc: "Generates a random float between the given zero (inclusive) and one (exclusive)."The
prnglib currently doesn't support generates number with one end or both end exclusive. So I have to make some ad-hoc functions that do it.I also try to make the test for these two functions, but I don't feed like I can write it the right way...