Always return 200 for OPTS UTF8 or OPTS UTF-8 ON #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirzak
changed the title
lurch
reviewed
Feb 27, 2023
pyftpdlib/handlers.py
Outdated
Comment on lines
3001
to
3002
| if arg and ';' not in arg: | ||
| raise ValueError('Invalid argument') |
There was a problem hiding this comment.
I wonder if this bit should be moved down to just above the facts = [x.lower() for x in arg.split(';')] line?
https://www.rfc-editor.org/rfc/rfc2389#section-4 says command-options = <format specified by individual FTP command> and I think the semicolon in command-options is specific to MLST?
There was a problem hiding this comment.
Indentation of raise ValueError seems incorrect
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 69.81% 69.72% -0.10%
==========================================
Files 9 9
Lines 3614 3623 +9
==========================================
+ Hits 2523 2526 +3
- Misses 1091 1097 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #266 and #531.
Took inspiration from vsftpd for 200 reply message - https://github.com/dagwieers/vsftpd/blob/ce2fa4288b92683f832c3b5179d5cb2a77d0750e/opts.c#L20
Let me know if additional changes are needed in order to merge it.