Skip to content

Add a BC layer in PhoneNumber serialize method#705

Merged
giggsey merged 1 commit intogiggsey:masterfrom
odolbeau:serialize-bc-layer
Jun 23, 2025
Merged

Add a BC layer in PhoneNumber serialize method#705
giggsey merged 1 commit intogiggsey:masterfrom
odolbeau:serialize-bc-layer

Conversation

@odolbeau
Copy link
Contributor

@odolbeau odolbeau commented Jun 20, 2025

While trying to upgrade the PhoneNumberBundle (see odolbeau/phone-number-bundle#193) my application wasn't able to deserialize an "old" serialized phone number.

I added a BC layer in PhoneNumber to allow deserialisation of an "old" CountryCodeSource (from int to enum).

@giggsey
Copy link
Owner

giggsey commented Jun 23, 2025

Thanks!

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (b01b0b6) to head (6cc74fd).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #705      +/-   ##
============================================
+ Coverage     85.98%   85.99%   +0.01%     
- Complexity     1302     1303       +1     
============================================
  Files            31       31              
  Lines          3481     3484       +3     
============================================
+ Hits           2993     2996       +3     
  Misses          488      488              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giggsey giggsey merged commit f72d490 into giggsey:master Jun 23, 2025
20 of 22 checks passed
@giggsey
Copy link
Owner

giggsey commented Jun 23, 2025

I expect Google will do a new release later this week

giggsey pushed a commit to giggsey/libphonenumber-for-php-lite that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants