Add a BC layer in PhoneNumber serialize method#705
Merged
giggsey merged 1 commit intogiggsey:masterfrom Jun 23, 2025
Merged
Conversation
Owner
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
============================================
+ Coverage 85.98% 85.99% +0.01%
- Complexity 1302 1303 +1
============================================
Files 31 31
Lines 3481 3484 +3
============================================
+ Hits 2993 2996 +3
Misses 488 488 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I expect Google will do a new release later this week |
giggsey
pushed a commit
to giggsey/libphonenumber-for-php-lite
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to upgrade the PhoneNumberBundle (see odolbeau/phone-number-bundle#193) my application wasn't able to deserialize an "old" serialized phone number.
I added a BC layer in
PhoneNumberto allow deserialisation of an "old"CountryCodeSource(from int to enum).