Skip to content

Fix PHP 8.5 deprecation#734

Merged
giggsey merged 4 commits intogiggsey:masterfrom
grzybu:php85
Jan 15, 2026
Merged

Fix PHP 8.5 deprecation#734
giggsey merged 4 commits intogiggsey:masterfrom
grzybu:php85

Conversation

@grzybu
Copy link
Contributor

@grzybu grzybu commented Jan 15, 2026

Fixes: Using null as an array offset is deprecated, use an empty string instead in PhoneNumberUtil:getRegionCodeForNumber

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (674d187) to head (5a1cbbd).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #734      +/-   ##
============================================
- Coverage     85.99%   85.94%   -0.05%     
- Complexity     1303     1304       +1     
============================================
  Files            31       31              
  Lines          3484     3430      -54     
============================================
- Hits           2996     2948      -48     
+ Misses          488      482       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giggsey
Copy link
Owner

giggsey commented Jan 15, 2026

Thanks!

I'm expecting a libphonenumber release from Google within the next few days, so this will go out as part of that. I'll also apply the same fix to libphonenumber-for-php-lite

@giggsey giggsey merged commit f7317f8 into giggsey:master Jan 15, 2026
21 of 22 checks passed
giggsey added a commit to giggsey/libphonenumber-for-php-lite that referenced this pull request Jan 15, 2026
Fixes: Using null as an array offset is deprecated, use an empty string instead in PhoneNumberUtil:getRegionCodeForNumber

Thanks @grzybu

Mirrors giggsey/libphonenumber-for-php#734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments