Relax type requirements for stopping criterion parameters #1941
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
The iteration stopping criterion currently requires that we specify the iteration count using an unsigned integer type, and fails even with integer literals like
with_iterations(1)with a hard-to-understand error message based on narrowing conversions in{}brace initialization. With residual norm criteria, the same happens when specifying double values for float parameters.This PR turns the error into a normal signed-unsigned/lossy conversion conversion warning and hopefully makes it easier to use:
Before:
After: