Skip to content

Improve the exception in the config #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve the exception in the config #1944

wants to merge 1 commit into from

Conversation

@yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Oct 31, 2025

It improves the exception information from the wrong config.

@yhmtsai yhmtsai self-assigned this Oct 31, 2025
@yhmtsai yhmtsai added the 1:ST:WIP This PR is a work in progress. Not ready for review. label Oct 31, 2025
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. mod:core This is related to the core module. labels Oct 31, 2025
@ginkgo-bot
Copy link
Member

ginkgo-bot commented Oct 31, 2025

Error: The following files need to be formatted:

benchmark/matrix_generator/matrix_generator.cpp
benchmark/utils/runner.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

upsj
upsj approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you maybe add a before/after error message to the PR description?

@yhmtsai
Copy link
Member Author

yhmtsai commented Nov 3, 2025

@upsj Yes, will do when I finish the work.
It is mainly to help exasim-project/FoamAdapter#138
However, I believe I did not improve that on that case yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upsj upsj upsj approved these changes

Assignees

@yhmtsai yhmtsai

Labels

1:ST:WIP This PR is a work in progress. Not ready for review. mod:core This is related to the core module. reg:testing This is related to testing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhmtsai @ginkgo-bot @upsj