Skip to content

Commit 41b1b93

Browse files
authored
Merge pull request #4190 from gitbutlerapp/remove-unused-rsqlite-dep
refactor: Remove rusqlite dependency and related code.
2 parents b4509ef + b886ff8 commit 41b1b93

File tree

4 files changed

+0
-63
lines changed

4 files changed

+0
-63
lines changed

Cargo.lock

Lines changed: 0 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ git2 = { version = "0.18.3", features = ["vendored-openssl", "vendored-libgit2"]
1616
uuid = { version = "1.8.0", features = ["serde"] }
1717
serde = { version = "1.0", features = ["derive"] }
1818
thiserror = "1.0.61"
19-
rusqlite = { version = "0.29.0", features = [ "bundled", "blob" ] }
2019
tokio = { version = "1.38.0", default-features = false }
2120

2221
gitbutler-git = { path = "crates/gitbutler-git" }

crates/gitbutler-core/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ rand = "0.8.5"
3434
regex = "1.10"
3535
reqwest = { version = "0.12.4", features = ["json"] }
3636
resolve-path = "0.1.0"
37-
rusqlite.workspace = true
3837
serde = { workspace = true, features = ["std"]}
3938
serde_json = { version = "1.0", features = [ "std", "arbitrary_precision" ] }
4039
sha2 = "0.10.8"

crates/gitbutler-core/src/id.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,6 @@ impl<T> Default for Id<T> {
4343
}
4444
}
4545

46-
impl<T> rusqlite::types::FromSql for Id<T> {
47-
fn column_result(value: rusqlite::types::ValueRef<'_>) -> rusqlite::types::FromSqlResult<Self> {
48-
Uuid::parse_str(value.as_str()?)
49-
.map(Into::into)
50-
.map_err(|error| rusqlite::types::FromSqlError::Other(Box::new(error)))
51-
}
52-
}
53-
54-
impl<T> rusqlite::ToSql for Id<T> {
55-
fn to_sql(&self) -> rusqlite::Result<rusqlite::types::ToSqlOutput<'_>> {
56-
Ok(rusqlite::types::ToSqlOutput::from(self.0.to_string()))
57-
}
58-
}
59-
6046
impl<T> PartialEq for Id<T> {
6147
fn eq(&self, other: &Self) -> bool {
6248
self.0.eq(&other.0)

0 commit comments

Comments
 (0)